[Agent] feat(duckstation): switch to Provenance-Emu fork, update submodule to latest master

[github-actions]

Summary

• Switches DuckStation submodule URL from stenzek/duckstation (upstream) to Provenance-Emu/duckstation (our fork)
• Updates submodule pointer to latest master: 125c3ec (2026-03-20: "Qt: Respond to QScreen refresh rate changes")
• Adds branch = master tracking in .gitmodules so future syncs pull from our fork

Since DuckStation never compiled against the old pinned commit, starting fresh from the latest fork master is the right approach. The fork was synced from upstream master on 2026-03-20.

Changes

• .gitmodules — URL updated to Provenance-Emu fork, branch tracking added
• Cores/DuckStation/duckstation — submodule pointer moved from e4f5904 to 125c3ec

Test plan

• Verify git submodule update --init Cores/DuckStation/duckstation fetches from Provenance-Emu fork
• Confirm submodule checks out at 125c3ec70fd1b4fdcf61d52500e5afad72be17e5
• Subsequent DuckStation build work can proceed from this base

Part of #3447
Part of #3425

🤖 Generated with Claude Code

[github-actions]

🤖 PR created. AI review starting automatically.

[Copilot]

Pull request overview

Updates the DuckStation submodule to point at the Provenance-Emu fork and advances the pinned submodule commit to a newer revision, enabling future work to build from an up-to-date fork baseline.

Changes:

• Switched DuckStation submodule URL from upstream (stenzek/duckstation) to Provenance-Emu/duckstation
• Updated the DuckStation submodule gitlink to commit 125c3ec70f...
• Added branch = master tracking for DuckStation in .gitmodules

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
Cores/DuckStation/duckstation	Advances the pinned submodule commit to a newer fork revision.
.gitmodules	Repoints the DuckStation submodule remote to the Provenance-Emu fork and sets branch tracking.
.changelog/3447.md	Documents the DuckStation submodule fork switch and update.

[Copilot]

The changelog entry uses relative wording (“latest master”) which will become inaccurate over time. Consider recording an immutable reference (e.g., the pinned commit 125c3ec70fd1b4fdcf61d52500e5afad72be17e5) instead of (or in addition to) ‘latest master’/a date so the change is always traceable.

Suggested change

	- **DuckStation submodule** — Switched submodule URL from upstream `stenzek/duckstation` to the Provenance-Emu fork and updated to latest master (2026-03-20).
	- **DuckStation submodule** — Switched submodule URL from upstream `stenzek/duckstation` to the Provenance-Emu fork and updated to commit `125c3ec70fd1b4fdcf61d52500e5afad72be17e5` on `master` (as of 2026-03-20).

[Copilot]

Adding branch = master only affects git submodule update --remote (and some tooling may ignore it); the repo will still be pinned to the gitlink commit for normal checkouts. If the intent is to make ‘sync to fork master’ a standard workflow, consider documenting the expected update command (and whether it should --merge/--rebase) in contributor docs to avoid inconsistent local/CI submodule states.

Suggested change

branch = master

[JoeMatt]

@claude please validate copilot review issues, improve, fix and then self-re review and mark copilot for re-review

[github-actions]

Copilot Review Audit — Complete

Progress

• Agent started
• Checked out branch agent/issue-3447
• Fetched all Copilot inline review comments (5 total)
• Audited all comments
• Fixed remaining nit: standardized placeholder naming in DEVELOPER.md
• Pushed changes and posted summary comment

Copilot Comments Summary

All 5 Copilot review comments addressed (4 in prior commits, 1 in this run).

Updated: 2026-03-25

[github-actions]

✅ Fixes pushed — addressed both Copilot review comments:

1. .changelog/3447.md — replaced "latest master" with the specific pinned commit hash 125c3ec70fd1b4fdcf61d52500e5afad72be17e5 for permanent traceability
2. DEVELOPER.md — added a new "Submodule Management" section documenting how to update Provenance-Emu fork submodules, clarifying the behavior of branch = vs the pinned gitlink, and the expected git submodule update --remote workflow

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

[Copilot]

git submodule update --remote --merge can fail or behave unexpectedly when the submodule is in the common detached-HEAD state (which is typical after a normal git submodule update). The docs should recommend a command sequence that works from a detached HEAD (e.g., using --remote without --merge, or explicitly checking out the target branch inside the submodule before updating), and clarify the precondition if --merge is kept.

[Copilot]

The placeholders in this section mix casing/styles (<CoreName> vs <corename> later). For readability and to reduce copy/paste errors, standardize the placeholder convention (e.g., consistently use <core-name> or <CoreName> everywhere, including the example commit message).

[JoeMatt]

@claude please validate copilot review issues, improve, fix and then self-re review and mark copilot for re-review

[github-actions]

✅ Fixes pushed — addressed all 4 Copilot review issues:

1. Changelog (.changelog/3447.md) — Already had the commit hash 125c3ec70fd1b4fdcf61d52500e5afad72be17e5 applied; no change needed.
2. .gitmodules branch = master — Informational comment; addressed by improved DEVELOPER.md docs explaining the behavior.
3. DEVELOPER.md --merge flag — Removed --merge from git submodule update --remote command and added an explicit warning that submodules are in detached-HEAD state after normal checkout, making --merge fail or produce unexpected results.
4. DEVELOPER.md placeholder casing — Fixed <corename> → <CoreName> in the commit message example for consistency.

[JoeMatt]

@claude please audit all Copilot review comments on this PR. For each comment:

1. Evaluate whether the concern is valid
2. Fix any valid issues (compile errors, logic bugs, missing null checks, incorrect API usage, etc.)
3. Note/dismiss nits that are style-only with a brief explanation

After addressing the review comments, do a self-review pass:

• Verify all changed files compile (check for unresolved symbols, missing imports, type mismatches)
• Check for any dead code, unused variables, or missing test coverage
• Ensure multi-platform compatibility (iOS + tvOS + macOS Catalyst)

Then re-request Copilot review.

[github-actions]

Copilot Review Audit — Completed

All Copilot review comments have been audited and addressed (across this and prior commits):

Comments Addressed

File	Copilot Concern	Resolution
.changelog/3447.md	Used "latest master" (imprecise)	Fixed in prior commit — now includes immutable commit hash 125c3ec70f...
.gitmodules	branch = master only affects --remote, needs docs	Addressed — DEVELOPER.md now explains this behavior clearly
DEVELOPER.md	Missing --init and sync prerequisite steps	Fixed in prior commit — both steps added to the bash example
DEVELOPER.md	--merge fails in detached-HEAD state	Fixed in prior commit — command uses --remote only, with a comment explaining why --merge is avoided
DEVELOPER.md	Placeholder inconsistency (<name> vs <CoreName>)	Fixed in this commit — changed <name> to <branch-name> for clarity

Self-Review Pass

• Compile check: No Swift/ObjC code changed — only .gitmodules, DEVELOPER.md, .changelog/3447.md, and the submodule gitlink. No compilation risk.
• Dead code: None introduced.
• Multi-platform: N/A (documentation and config changes only).
• Submodule: The DuckStation gitlink points to 125c3ec70f on Provenance-Emu/duckstation — correct and intentional.

Fixes pushed — placeholder naming standardized; all prior Copilot concerns already addressed