Few fixes and handle modification consistently#300
Merged
tazend merged 3 commits intoPySlurm:mainfrom Jun 2, 2023
Merged
Conversation
tazend
added a commit
that referenced
this pull request
Jul 19, 2023
- handle modification of objects via `modify()` consistently - use correct list of node states when modifying the node state - remove `consumable_resource` attribute of Partition class again, logic is merged into the `select_type_parameters` attribute
tazend
added a commit
that referenced
this pull request
Jul 19, 2023
- handle modification of objects via `modify()` consistently - use correct list of node states when modifying the node state - remove `consumable_resource` attribute of Partition class again, logic is merged into the `select_type_parameters` attribute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modify()consistentlyconsumable_resourceattribute of Partition class again, logic is merged into theselect_type_parametersattribute