Wrong dependencies shown

[JeroenDeDauw]

The visualization shows Item and Entity as dependency, while it should be ItemId and EntityIdParsingException.

Code from https://github.com/wmde/WikibaseDataModel at fa45c0e2426b6f386581d26e30cebb9abefee822

class ItemIdParser implements EntityIdParser {

    /**
     * @param string $idSerialization
     *
     * @throws EntityIdParsingException
     * @return ItemId
     */
    public function parse( $idSerialization ) {
        try {
            return new ItemId( $idSerialization );
        } catch ( InvalidArgumentException $ex ) {
            throw new EntityIdParsingException( $ex->getMessage() );
        }
    }

}

Quality Analyzer at 38525e7

Report generated with

bin/analyze analyze ../WikibaseDataModel/src/
bin/analyze serve

FireFox 41.0.2, Kubuntu

[kore]

Thanks for the bug report. I understand where it comes from and will fix that.

If you want to take a look at it yourself because I won't be able to tackle it until next week:

• The related source is in src/js/modules/dependencies/model.js
• The tests are in test/js/modules/dependencies/model.js

Run ant test-unit or ant watch and grunt test-unit to check the test result.

The base issue is that until now a starting string check is executed to cope for various things. Not sure what the best fix would be, yet.

[JeroenDeDauw]

Did you get to this? :)