Skip to content

Fix secret save error when contain chinese character#203

Merged
wilhelmguo merged 2 commits intoQihoo360:masterfrom
BennieMeng:feature/secret-chinese-support
Jan 9, 2019
Merged

Fix secret save error when contain chinese character#203
wilhelmguo merged 2 commits intoQihoo360:masterfrom
BennieMeng:feature/secret-chinese-support

Conversation

@BennieMeng
Copy link
Copy Markdown
Collaborator

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind bug

What this PR does / why we need it:
secret save chinese lead to error

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #193

@BennieMeng BennieMeng requested a review from wilhelmguo January 7, 2019 08:01
@wilhelmguo wilhelmguo added the kind/bug Categorizes issue or PR as related to a bug. label Jan 9, 2019
@wilhelmguo wilhelmguo merged commit a9dc255 into Qihoo360:master Jan 9, 2019
@BennieMeng BennieMeng deleted the feature/secret-chinese-support branch August 28, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There is a js error when secret contains chinese character

2 participants