Skip to content

Feature/ace switch error notify#34

Merged
wilhelmguo merged 3 commits intoQihoo360:masterfrom
BennieMeng:feature/ace-switch-error-notify
Nov 21, 2018
Merged

Feature/ace switch error notify#34
wilhelmguo merged 3 commits intoQihoo360:masterfrom
BennieMeng:feature/ace-switch-error-notify

Conversation

@BennieMeng
Copy link
Copy Markdown
Collaborator

针对目前出现的用户在编辑ace模板时候内容为空或者出错无法切换语言的问题。
修改逻辑为:1. 为空时候可以切换; 2. 内容出错时候点击切换给出提示;3. 内容为空时候统一输出为空字符串。

@BennieMeng
Copy link
Copy Markdown
Collaborator Author

@wilhelmguo @chengyumeng pls review

@wilhelmguo wilhelmguo added sig/frontend Categorizes an issue or PR as relevant to sig-frontend. kind/enhancement Categorizes issue or PR as related to enhancement. labels Nov 21, 2018
@wilhelmguo
Copy link
Copy Markdown
Collaborator

/lgtm

@wilhelmguo wilhelmguo merged commit 0c8ea9c into Qihoo360:master Nov 21, 2018
@BennieMeng BennieMeng deleted the feature/ace-switch-error-notify branch August 28, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Categorizes issue or PR as related to enhancement. sig/frontend Categorizes an issue or PR as relevant to sig-frontend.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants