Skip StateTomography test until Qiskit Experiments is ready for 2.0#55
Merged
mtreinish merged 2 commits intoQiskit:mainfrom Mar 5, 2025
Merged
Conversation
mtreinish
approved these changes
Mar 5, 2025
Member
mtreinish
left a comment
mtreinish
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing this.
Comment on lines
+27
to
+31
| @unittest.skipIf( | ||
| tuple(map(int, qiskit.__version__.split(".")[:2])) >= (2, 0), | ||
| "Skipping test until Qiskit Experiments is ready for Qiskit 2.0. " | ||
| "Tracked in: https://github.com/Qiskit/qiskit-neko/issues/54", | ||
| ) |
Member
There was a problem hiding this comment.
I would have just unconditionally skipped this but this is clever and lets us keep running things on 1.4.x and will ensure that experiments doesn't regress/break compatibility with 1.4.x when it's updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BackendV1andqiskit.qobjremovals in Qiskit/qiskit#13793 cause the test inqiskit_neko/tests/experiments/test_tomography.pyto fail. This is part of the tests that are blocking the Qiskit/qiskit#13793 and Qiskit/qiskit#13872 PR in Qiskit from being merged.There is a PR in Qiskit Experiments that address these removals: qiskit-community/qiskit-experiments#1526. Until it is merged, we need to skip this failing test.
Tracked in #54