More quantum circuit library refactoring

[alexanderivrii]

Summary

As a part of circuit library refactoring #13046, more quantum circuits now have their "modern" variants,
either as gates or as synthesis methods.

This PR adds:

• GraphState -> GraphStateGate
• FourierChecking -> fourier_checking(...)
• UnitaryOverlap -> unitary_overlap(...)
• HiddenLinearFunction -> hidden_linear_function(...)
• PhaseEstimation -> phase_estimation(...)

Details and comments

For now these are all in Python.

[qiskit-bot]

One or more of the following people are relevant to this code:

• @Cryoris
• @Qiskit/terra-core
• @ajavadia

[Cryoris]

Looks great, thanks for taking care of these! I left some minor comments below.

[coveralls]

Pull Request Test Coverage Report for Build 11661267084

Details

• 108 of 108 (100.0%) changed or added relevant lines in 6 files are covered.
• 5 unchanged lines in 4 files lost coverage.
• Overall coverage increased (+0.04%) to 88.755%

---

Files with Coverage Reduction	New Missed Lines	%
crates/accelerate/src/unitary_synthesis.rs	1	92.2%
crates/qasm2/src/expr.rs	1	94.02%
crates/accelerate/src/two_qubit_decompose.rs	1	92.09%
crates/qasm2/src/lex.rs	2	92.48%

Totals
Change from base Build 11636461507:	0.04%
Covered Lines:	76500
Relevant Lines:	86192

---

💛 - Coveralls

[alexanderivrii]

Thanks @Cryoris, I have addressed the suggestions from the code review, and also added some missing tests, and added the functions to the API as in the other PRs.

[Cryoris]

Looks great, thank you! 🙂