Add grover_operator function#13365
Merged
ElePT merged 5 commits intoQiskit:mainfrom Nov 5, 2024
Merged
Conversation
Collaborator
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 11688478692Details
💛 - Coveralls |
and know how :context: is to be used
ElePT
reviewed
Nov 4, 2024
Comment on lines
+162
to
+163
| For a large number of qubits, the multi-controlled X gate used for the zero-reflection | ||
| can be synthesized in different fashion. Depending on the number of available qubits, |
Contributor
There was a problem hiding this comment.
Suggested change
| For a large number of qubits, the multi-controlled X gate used for the zero-reflection | |
| can be synthesized in different fashion. Depending on the number of available qubits, | |
| For a large number of qubits, the multi-controlled X gate used for the zero-reflection | |
| can be synthesized in different fashions. Depending on the number of available qubits, |
Comment on lines
+182
to
+184
| # add extra bits that can be used as scratch space | ||
| grover_op.add_bits([Qubit() for _ in range(num_qubits)]) | ||
| print("2q depth w/ scratch qubits:", tqc.depth(filter_function=is_2q)) # < 100 |
Contributor
There was a problem hiding this comment.
shouldn't you retranspile after adding the extra bits in this example?
Comment on lines
+410
to
+411
| The :func:`.grover_operator` implements the same functionality but keeping the | ||
| :class:`.MCXGate` abstract, such that the compiler may choose the optimal decomposition. |
Contributor
There was a problem hiding this comment.
What about:
Suggested change
| The :func:`.grover_operator` implements the same functionality but keeping the | |
| :class:`.MCXGate` abstract, such that the compiler may choose the optimal decomposition. | |
| The :func:`.grover_operator` implements the same functionality but keeping the | |
| :class:`.MCXGate` abstract, such that the compiler may choose the optimal decomposition. | |
| We recommend using :func:`.grover_operator` for performance reasons. |
| Grover's algorithm and amplitude estimation/amplification. This function is similar to | ||
| :class:`.GroverOperator`, but does not require choosing the implementation of the | ||
| multi-controlled X gate a-priori and let's the compiler choose the optimal decomposition | ||
| instead. |
Contributor
There was a problem hiding this comment.
Given the amount of examples you have in the docstring, I would copy-paste one into the reno for quick reference.
| expected.compose(zero_reflection, inplace=True) | ||
| expected.h(0) | ||
| self.assertEqual(expected, grover_op.decompose()) | ||
| self.assertEqual(expected, grover_op if use_function else grover_op.decompose()) |
Contributor
There was a problem hiding this comment.
This tests makes me think that we should mention in the reno and docstring that the output of the new constructor is a series of gates instead of a "black box". This is actually the main user-facing difference I see (besides the mcx detail)
ShellyGarion
added
the
Changelog: Added
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
ElePT
approved these changes
Nov 5, 2024
Contributor
ElePT
left a comment
ElePT
left a comment
There was a problem hiding this comment.
LGTM! thanks for applying the REviwe comments :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #13046: The
grover_operatoras function.Details and comments
This function is similar to the
GroverOperator, but does not require choosing the implementation of the multi-controlled X gate a-priori and let's the compiler choose the optimal decomposition instead.