Add missing pulse-related deprecation#13392
Merged
ElePT merged 1 commit intoQiskit:mainfrom Nov 4, 2024
Merged
Conversation
This commit deprecates `inst_map` in `PassManagerConfig.__init__`. It should have been part of the pulse deprecation PR Qiskit#13164 but I somehow missed to covere it. We're already in our feature freeze period for version 1.3 but since this is not a new feature but rather an addendum to the pulse deprecation PR we should squeeze this in as well.
Collaborator
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 11649694905Details
💛 - Coveralls |
ElePT
approved these changes
Nov 4, 2024
Contributor
ElePT
left a comment
ElePT
left a comment
There was a problem hiding this comment.
I think that it makes a lot of sense to include this PR in the release, else the deprecation would be incomplete. I'm glad you caught this on time! It totally flew over my head.
eliarbel
added
the
Changelog: Deprecated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit deprecates
inst_mapinPassManagerConfig.__init__. It should have been part of the pulse deprecation PR #13164 but I somehow missed to cover it. We're already in our feature freeze period for version 1.3 but since this is not a new feature but rather an addendum to the pulse deprecation PR we should squeeze this in as well.