Remove fake backends based on `BackendV1` and related tools by ElePT · Pull Request #13805 · Qiskit/qiskit

ElePT · 2025-02-06T21:04:11Z

Summary

This PR branches off #13793 and contains the changes related to the fake backend removal. This PR is built on top of #13722 and currently BLOCKED by it.

Details and comments

TODOs:

remove stray prints
fix benchmarking test
fix visualization tests
reno

coveralls · 2025-02-10T11:53:28Z

Pull Request Test Coverage Report for Build 13587359090

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
1343 unchanged lines in 55 files lost coverage.
Overall coverage decreased (-0.9%) to 86.961%

Files with Coverage Reduction	New Missed Lines	%
qiskit/primitives/backend_estimator_v2.py	1	97.71%
qiskit/pulse/instructions/acquire.py	1	89.13%
qiskit/pulse/library/symbolic_pulses.py	1	92.75%
qiskit/pulse/library/waveform.py	1	97.83%
qiskit/result/counts.py	1	98.78%
qiskit/result/distributions/quasi.py	1	97.96%
qiskit/user_config.py	1	86.87%
qiskit/utils/units.py	1	93.55%
qiskit/providers/models/init.py	2	77.78%
qiskit/circuit/classical/expr/expr.py	4	96.67%

Totals
Change from base Build 13534039243:	-0.9%
Covered Lines:	76032
Relevant Lines:	87432

💛 - Coveralls

qiskit-bot · 2025-02-11T12:51:17Z

One or more of the following people are relevant to this code:

@enavarro51
@Qiskit/terra-core
@ajavadia
@levbishop
@nkanazawa1989
@t-imamichi

…y tests that checked V1 functionality, mitigators (independent removal). Update rest of unit tests to use GenericBackendV2

…d in 2.0 so no alternative is provided)

… (visual tests).

eliarbel

Looks good overall. I've left some minor comments regarding a reno and some tests.

Co-authored-by: Eli Arbel <46826214+eliarbel@users.noreply.github.com>

…move non-relevant tests

…ake-v1. Fix conflicts.

eliarbel

Thanks @ElePT for making all the changes. One last typo fix in the reno which I've missed in my previous review and we're done (better to address now rather than wait for the big reno review just before the release)

Co-authored-by: Eli Arbel <46826214+eliarbel@users.noreply.github.com>

mtreinish

This LGTM. I had a few inline comments but nothing critical mostly idle musings as a I read through the code. There was one question about one test being added but it's not a blocker.

mtreinish · 2025-02-28T12:00:19Z

            If the time unit is 'dt', the duration must be an integer.
        dt: Backend sample time (resolution) in seconds.
-            If ``None`` (default), ``backend.configuration().dt`` is used.
+            If ``None`` (default), ``backend.dt`` is used.


This might have slipped in from the backendv1 removal pr. Not a big deal though

mtreinish · 2025-02-28T12:03:19Z

        large_qasm_path = os.path.join(self.qasm_path, "test_eoh_qasm.qasm")
        self.large_qasm = QuantumCircuit.from_qasm_file(large_qasm_path)
-        self.melbourne = Fake20QV1()
+        self.melbourne = GenericBackendV2(num_qubits=20, coupling_map=MELBOURNE_CMAP, seed=0)


Unfortunately this will invalidate the benchmarking results for these benchmarks. There's no helping it since we're removing the code they rely on. But I'm going to miss the data:

https://qiskit.github.io/qiskit/#transpiler_levels.TranspilerLevelBenchmarks.time_quantum_volume_transpile_50_x_20?python=3.11

mtreinish · 2025-02-28T12:06:44Z

        ).result()
        self.assertEqual(result.get_counts(qc), {"010000": 1024})

+    def test_parallel_compile(self):


Did this test get lost? Also this won't trigger parallelism by default, we have a dedicated class that overrides the defaults to ensure we run under multiprocessing here: https://github.com/Qiskit/qiskit/blob/main/test/python/compiler/test_transpiler.py#L2628

But there is no harm in having this test.

mtreinish · 2025-02-28T12:08:59Z

-    def setUp(self):
-        super().setUp()
-        with self.assertWarns(DeprecationWarning):
-            backend = FakeOpenPulse2Q()


I find it disappointing that we didn't have tests in this file that just built a BackendConfiguration standalone. Not a comment on this PR, but more just a general comment. Removing these makes sense since we're removing BackendV1 after this, I was just surprised to see the file deleted here.

Comments addressed

ElePT force-pushed the remove-fake-v1 branch from ca5a45b to 6c8d616 Compare February 10, 2025 20:12

ElePT marked this pull request as ready for review February 11, 2025 12:51

ElePT requested review from a team, eggerdj, jyu00, nkanazawa1989, nonhermitian and wshanks as code owners February 11, 2025 12:51

ElePT changed the title ~~[WIP] Remove fake backends based on BackendV1 and related tools~~ Remove fake backends based on BackendV1 and related tools Feb 11, 2025

ElePT added the on hold Can not fix yet label Feb 17, 2025

ElePT mentioned this pull request Feb 17, 2025

Remove deprecated BackendV1 elements, including base class, providers.models and qobj modules #13793

Merged

3 tasks

ElePT added this to the 2.0.0 milestone Feb 17, 2025

eliarbel mentioned this pull request Feb 18, 2025

Remove pulse module files, pulse visualization and final cleanup #13872

Merged

ElePT added 5 commits February 18, 2025 19:48

Remove FakeBackend, FakeQasmBackend, FakePulseBackend, subclasses, an…

ab66613

…y tests that checked V1 functionality, mitigators (independent removal). Update rest of unit tests to use GenericBackendV2

Remove FakeBackend references from docs (these classes will be remove…

4f078bd

…d in 2.0 so no alternative is provided)

Fix lint and apply desperate measures until better measures are found…

5d99e29

… (visual tests).

Add renos

25d0858

Fix scheduling tests, lints and docs issue.

9cf239c

ElePT force-pushed the remove-fake-v1 branch from fc3c929 to 9cf239c Compare February 18, 2025 19:01

ElePT removed the on hold Can not fix yet label Feb 18, 2025

ElePT mentioned this pull request Feb 19, 2025

Remove deprecated legacy scheduling passes #13876

Merged

eliarbel self-assigned this Feb 20, 2025

eliarbel requested changes Feb 23, 2025

View reviewed changes

eliarbel reviewed Feb 23, 2025

View reviewed changes

Comment thread releasenotes/notes/remove-fake-v1-backends-b66bc47886702904.yaml Outdated

1ucian0 assigned ElePT Feb 24, 2025

ElePT and others added 2 commits February 26, 2025 09:55

Apply suggestions from Eli's code review

e6e6735

Co-authored-by: Eli Arbel <46826214+eliarbel@users.noreply.github.com>

Migrate relevant fake backend tests to test_generic_backend_v2.py, re…

7af75f6

…move non-relevant tests

ElePT added 2 commits February 26, 2025 10:24

Merge branch 'main' of https://github.com/Qiskit/qiskit into remove-f…

1dc324e

…ake-v1. Fix conflicts.

Fix merge conflict, apply review suggestions reno

a16fba0

eliarbel previously requested changes Feb 28, 2025

View reviewed changes

Comment thread releasenotes/notes/remove-fake-v1-backends-b66bc47886702904.yaml Outdated

Fix reno typo

dce1983

Co-authored-by: Eli Arbel <46826214+eliarbel@users.noreply.github.com>

mtreinish approved these changes Feb 28, 2025

View reviewed changes

mtreinish enabled auto-merge February 28, 2025 12:11

mtreinish added this pull request to the merge queue Feb 28, 2025

Merged via the queue into Qiskit:main with commit fcb5d29 Feb 28, 2025

ElePT added the Changelog: Removed Add a "Removed" entry in the GitHub Release changelog. label Mar 13, 2025

raynelfss mentioned this pull request Apr 1, 2025

Fix: Incorrect initialization of BackendV2 for transpiler_level ASV Test #14152

Merged

Conversation

ElePT commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details and comments

Uh oh!

coveralls commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 13587359090

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

Uh oh!

qiskit-bot commented Feb 11, 2025

Uh oh!

eliarbel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eliarbel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mtreinish left a comment

Choose a reason for hiding this comment

Uh oh!

mtreinish Feb 28, 2025

Choose a reason for hiding this comment

Uh oh!

mtreinish Feb 28, 2025

Choose a reason for hiding this comment

Uh oh!

mtreinish Feb 28, 2025

Choose a reason for hiding this comment

Uh oh!

mtreinish Feb 28, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ElePT commented Feb 6, 2025 •

edited

Loading

coveralls commented Feb 10, 2025 •

edited

Loading