Remove calibrations APIs and related functionality #13861
Merged
ElePT merged 33 commits intoQiskit:mainfrom Mar 2, 2025
Merged
Remove calibrations APIs and related functionality #13861ElePT merged 33 commits intoQiskit:mainfrom
ElePT merged 33 commits intoQiskit:mainfrom
Conversation
Fix some doc issues
Co-authored-by: Raynel Sanchez <87539502+raynelfss@users.noreply.github.com>
This commit removes pulse-related functionality from GenericBackendV2, as part of Pulse removal in Qiskit 2.0. This includes the ability to initialize the backend with custom calibrations and query it for channel information. Also, various clean ups where made to accommodate for the updated API of GenericBackendV2.
eliarbel
added
on hold
eliarbel
added
mod: transpiler
eliarbel
requested review from
a team,
eggerdj,
jyu00,
nkanazawa1989,
nonhermitian and
wshanks
as code owners
Collaborator
|
One or more of the following people are relevant to this code:
|
ElePT
previously approved these changes
Feb 28, 2025
Contributor
ElePT
left a comment
ElePT
left a comment
There was a problem hiding this comment.
LGTM!! Thanks for this thorough PR. I have a couple of comments but they are tiny and given the queue of removals I would merge this PR now regardless of them.
| # does this run have uncalibrated gates? | ||
| uncalibrated_p = not has_cals_p or any(not dag._has_calibration_for(g) for g in old_run) | ||
| # does this run have gates not in the image of ._decomposers _and_ uncalibrated? | ||
| # does this run have gates not in the image of ._decomposers? |
Contributor
There was a problem hiding this comment.
I find this comment a bit cryptic but probably not the time to pick on it either.
Member
Author
There was a problem hiding this comment.
This is the original comment for this execution path. I agree it's cryptic especially since what is .decomposers. Also agree we should not try to address this here and now.
Member
Author
|
Thanks @ElePT for the review and comments, all applied. There was a stuck job from yesterday before your review, hopefully this time it'll go through. |
ElePT
approved these changes
Mar 2, 2025
This was referenced Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the calibration functionality from everywhere in Qiskit, outside of Pulse itself. This includes things like the
calibrationsproperty inQuantumCircuitandDAGCircuit, andTarget's support for calibrations. It also removes transitive dependencies on the calibrations functionality, e.g. within passes and the scheduler.Details and comments
The following user-facing parts have been removed (alongside any internal dependencies):
calibration,has_calibration_foretc.) fromQuantumCircuit,DAGCircuit,Target,DAGDependencyandInstructionProperties.inst_mapargument fromgenerate_preset_pass_manager,transpile,PassManagerConfigandTarget.from_configuration.qiskit.schedulermodule has been removed.This PR is based on changes introduced in: #13814Part of #13662