Fix wheel builds for i686 Linux#13967
Merged
1ucian0 merged 1 commit intoQiskit:stable/1.4from Mar 7, 2025
Merged
Conversation
In the 1.4.1 release the i686 linux wheel builds failed because the recent release of rustup 1.28.0 and 1.28.1 added a runtime dependency on libatomic to download and install the rust compiler. The i686 manylinux container we run the wheel builds in didn't contain this library so rustup errored and crashed the build. This commit fixes this issue by installing libatomic prior to running rustup. This fix was used in a throwaway branch to push out the 1.4.1 release on PyPI, but this fixes it for real for when we publish 1.4.2.
Collaborator
|
One or more of the following people are relevant to this code:
|
mtreinish
added
type: qa
mtreinish
added
the
ci: test wheels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the 1.4.1 release the i686 linux wheel builds failed because the recent release of rustup 1.28.0 and 1.28.1 added a runtime dependency on libatomic to download and install the rust compiler. The i686 manylinux container we run the wheel builds in didn't contain this library so rustup errored and crashed the build. This commit fixes this issue by installing libatomic prior to running rustup. This fix was used in a throwaway branch to push out the 1.4.1 release on PyPI, but this fixes it for real for when we publish 1.4.2.
Details and comments