Skip to content

Remove mention of toffoli method in CCXGate documentation#14080

Merged
jakelishman merged 1 commit intoQiskit:mainfrom
LenaPer:main
Mar 24, 2025
Merged

Remove mention of toffoli method in CCXGate documentation#14080
jakelishman merged 1 commit intoQiskit:mainfrom
LenaPer:main

Conversation

@LenaPer
Copy link
Copy Markdown
Contributor

@LenaPer LenaPer commented Mar 24, 2025

Summary

Fixes #14079

In the current documentation for the CCXGate, there is a mention of the toffoli method which doesn't exist anymore for QuantumCircuit, see release note for Qiskit 1.0. This PR removes it.

@LenaPer LenaPer requested a review from a team as a code owner March 24, 2025 15:46
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Mar 24, 2025
@qiskit-bot
Copy link
Copy Markdown
Collaborator

qiskit-bot commented Mar 24, 2025

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 24, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jakelishman
jakelishman approved these changes Mar 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jakelishman jakelishman added documentation Something is not clear or an error documentation stable backport potential Make Mergify open a backport PR to the most recent stable branch on merge. Changelog: None Do not include in the GitHub Release changelog. labels Mar 24, 2025
@jakelishman
Copy link
Copy Markdown
Member

jakelishman commented Mar 24, 2025

@Mergifyio backport stable/1.4 stable/2.0

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 24, 2025 •
edited
Loading

backport stable/1.4 stable/2.0

✅ Backports have been created

Details

@jakelishman jakelishman enabled auto-merge March 24, 2025 15:56
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 24, 2025

Pull Request Test Coverage Report for Build 14039652605

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 26 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 88.047%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 8 91.98%
crates/qasm2/src/parse.rs 18 96.68%
Totals Coverage Status
Change from base Build 14034596400: -0.03%
Covered Lines: 72605
Relevant Lines: 82462
💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Mar 24, 2025
Merged via the queue into Qiskit:main with commit 15b1e5d Mar 24, 2025
21 checks passed
mergify Bot pushed a commit that referenced this pull request Mar 24, 2025
@LenaPer @mergify
removed mention of toffoli method which doesn't exist anymore (#14080)
5a4ff8c 
(cherry picked from commit 15b1e5d)
@mergify mergify Bot mentioned this pull request Mar 24, 2025
Merged
mergify Bot pushed a commit that referenced this pull request Mar 24, 2025
@LenaPer @mergify
removed mention of toffoli method which doesn't exist anymore (#14080)
ec3d335 
(cherry picked from commit 15b1e5d)
@mergify mergify Bot mentioned this pull request Mar 24, 2025
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Mar 25, 2025
@mergify @LenaPer
removed mention of toffoli method which doesn't exist anymore (#14080) (
7cb8bf8 
#14087)

(cherry picked from commit 15b1e5d)

Co-authored-by: LenaPer <62985492+LenaPer@users.noreply.github.com>
github-merge-queue Bot pushed a commit that referenced this pull request Mar 26, 2025
@mergify @LenaPer @mtreinish
removed mention of toffoli method which doesn't exist anymore (#14080) (
01e0c9b 
#14086)

(cherry picked from commit 15b1e5d)

Co-authored-by: LenaPer <62985492+LenaPer@users.noreply.github.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakelishman jakelishman jakelishman approved these changes

Assignees

No one assigned

Labels

Changelog: None Do not include in the GitHub Release changelog. Community PR PRs from contributors that are not 'members' of the Qiskit repo documentation Something is not clear or an error documentation stable backport potential Make Mergify open a backport PR to the most recent stable branch on merge.

Projects

Contributor Monitoring
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CCXGate documentation mentions outdated toffoli method

5 participants

@LenaPer @qiskit-bot @CLAassistant @jakelishman @coveralls
⚡