PBC transformations for C#15756
Conversation
Cryoris
added
Changelog: Added
|
One or more of the following people are relevant to this code:
|
|
Quick q: how tf did we manage to trigger an Azure failure on this PR? hahaha |
|
Very good question lol, it says it's a merge conflict but that would look differently, no? |
|
would you like to update this PR following #15502 ? |
ShellyGarion
left a comment
ShellyGarion
left a comment
There was a problem hiding this comment.
Some minor comments on the names.
| Ok(dag) => dag, | ||
| Err(_) => panic!("Internal Circuit -> DAG conversion failed"), | ||
| }; | ||
| // TODO: Potentially propagate exit code to the user |
There was a problem hiding this comment.
yep, but this is for after this PR since it requires changing different files to return other things than PyResult
There was a problem hiding this comment.
I don't think this TODO comment helps for now, so I am in favor of removing it.
|
Note: this PR should be updated after #15690 is merged! |
|
FYI I'll wait on updating this PR until after #15754 is merged to avoid further mixups |
Cryoris
force-pushed
the
pbc-trafo-for-c
branch
from
5260327 to
0dba1d4
Compare
alexanderivrii
left a comment
alexanderivrii
left a comment
There was a problem hiding this comment.
Thanks Julien. I especially like the C-based testing. Left a few small comments.
| Ok(dag) => dag, | ||
| Err(_) => panic!("Internal Circuit -> DAG conversion failed"), | ||
| }; | ||
| // TODO: Potentially propagate exit code to the user |
There was a problem hiding this comment.
I don't think this TODO comment helps for now, so I am in favor of removing it.
- additional test if litinski is noop - update test names - remove some idle code
alexanderivrii
left a comment
alexanderivrii
left a comment
There was a problem hiding this comment.
Thanks for quick updates, LGTM!
5 participants
Summary
Adds the Litinski transformation to the C API, via
qk_transpiler_pass_standalone_litinski_transformation. Depending on when #15502 merges, we can also add that pass to the C API for feature parity here.Details and comments
Based on top of #15720 and #15754.
The logic is quite straightforward, the main additions are in the tests. We might want to add some simpler way of constructing PBC circuits than with the ZX arrays, similar as the test does here.