Support phase gates in LitinskiTransformation#15773
Support phase gates in LitinskiTransformation#15773alexanderivrii merged 6 commits intoQiskit:mainfrom
LitinskiTransformation#15773Conversation
Supporting phase gates is straightforward and there's no reason we would require the compiler to first map to RZ. This commit does not tackle extensions of the Litinski transformation code to generic rotations, which is something we should add in the soon future.
Cryoris
added
Changelog: Added
|
One or more of the following people are relevant to this code:
|
ShellyGarion
left a comment
ShellyGarion
left a comment
There was a problem hiding this comment.
Thanks @Cryoris - I think this is a nice addition to the Litinski pass.
I have some minor comments and there is some clippy error.
| --- | ||
| features_transpiler: | ||
| - The :class:`.LitinskiTransformation` now also supports circuits with | ||
| :class:`.PhaseGate` and :class:`.U1Gate` instructions. Previously, the only |
There was a problem hiding this comment.
should we relate to U1Gate here since it's deprecated?
There was a problem hiding this comment.
Good question - since users could have circuits defined in terms of U1Gate, since it's still part of the official API and supported, I added it here since it doesn't really add any overhead to handle it
ShellyGarion
left a comment
ShellyGarion
left a comment
There was a problem hiding this comment.
LGTM. @alexanderivrii - do you have any comments?
|
putting it on-hold for 2.5 |
|
any idea why test_p is failing now? |
|
Yeah because in #15764 we added the |
…a into litinski-phase-gates
Cryoris
dismissed stale reviews from alexanderivrii and ShellyGarion
via
33669a0
ShellyGarion
left a comment
ShellyGarion
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix!
4 participants
Summary
Supporting phase gates is straightforward and there's no reason we would require the compiler to first map to RZ. This commit does not tackle extensions of the Litinski transformation code to generic rotations, which is something we should add in the soon future.