Update factor 2 in hard-coded angles in convert_to_pauli_rotations.rs#15787
Merged
alexanderivrii merged 2 commits intoQiskit:mainfrom Mar 22, 2026
Merged
Update factor 2 in hard-coded angles in convert_to_pauli_rotations.rs#15787alexanderivrii merged 2 commits intoQiskit:mainfrom
convert_to_pauli_rotations.rs#15787alexanderivrii merged 2 commits intoQiskit:mainfrom
Conversation
ShellyGarion
added
the
Changelog: None
Collaborator
|
One or more of the following people are relevant to this code:
|
alexanderivrii
approved these changes
Mar 22, 2026
Member
alexanderivrii
left a comment
alexanderivrii
left a comment
There was a problem hiding this comment.
Thanks Shelly, I admire your diligence - changing all the entries in every table so that we do not need to multiply by 2 later. But I agree that it's more consistent this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The angles in
convert_to_pauli_rotations.rswere originally computed forPauliEvolutionGate.When we replaced it by
PauliProductRotationGate, we didn't change the angles, just added a fator 2.0Now we update the hard-coded angles and remove the factor 2.0.
Details and comments