Add fixed size 2q matrix methods to operations and PackedInstruction#15858
Merged
alexanderivrii merged 1 commit intoQiskit:mainfrom Mar 25, 2026
Merged
Add fixed size 2q matrix methods to operations and PackedInstruction#15858alexanderivrii merged 1 commit intoQiskit:mainfrom
alexanderivrii merged 1 commit intoQiskit:mainfrom
Conversation
This commit adds new methods to the circuit operation types and the PackedInstruction type to support getting fixed size 2q matrices. 2q matrices are only 16 complex numbers and are commonly used in the transpiler as part of peephole optimization and other optimizations. Using a fixed size array for these will avoid needing heap allocation and also let the compiler potentially do more compile time optimization because the compiler knows exactly how many values are being used for operations. We already exposed these methods for 1q gates for the same reason, this just expands it to 2q gates. We probably won't go beyond this for 3q gates however, because they're 8x8 so too large and also are not as commonly used as 2q gates and matrices.
mtreinish
added
Changelog: None
Collaborator
|
One or more of the following people are relevant to this code:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds new methods to the circuit operation types and the PackedInstruction type to support getting fixed size 2q matrices. 2q matrices are only 16 complex numbers and are commonly used in the transpiler as part of peephole optimization and other optimizations. Using a fixed size array for these will avoid needing heap allocation and also let the compiler potentially do more compile time optimization because the compiler knows exactly how many values are being used for operations. We already exposed these methods for 1q gates for the same reason, this just expands it to 2q gates. We probably won't go beyond this for 3q gates however, because they're 8x8 so too large and also are not as commonly used as 2q gates and matrices.
Details and comments