-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add Rust matrix support for PauliProductRotation #15879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7d3f417
feat(circuit/rust): add matrix methods for PauliProductRotation
Adithyaphani 97b1fb6
Refactor PauliProductRotation matrix support to reuse SparsePauliOp l…
Adithyaphani bb1dad9
Resolve merge conflict in operations.rs
Adithyaphani 0d8e92f
Add local Pauli matrix helper for PauliProductRotation
Adithyaphani 5435705
Format PauliProductRotation matrix tests
Adithyaphani c163201
Make PauliProductRotation matrix tests unittest-compatible and fix co…
Adithyaphani 2dec214
Remove standalone PPR matrix test file as tests are moved to existing…
Adithyaphani b20e4f0
Refactor PPR matrix logic and apply cargo fmt formatting
Adithyaphani ef5a9e9
Merge upstream/main and finalize PPR matrix fixes
Adithyaphani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, did you relate to Alexander's comment on using https://docs.rs/ndarray/latest/ndarray/linalg/fn.kron.html ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in addition, note that you should use
cargo fmtThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out. I’ve updated the implementation to avoid the custom kron helper and aligned it with the existing ndarray Kronecker-product path as suggested.
Noted — I’ve also run
cargo fmton the updated Rust code in the follow-up commit.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, in addition please run
cargo checkandcargo clippyas there are some rust errorsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve re-run
cargo checkandcargo clippywith all targets and features, and addressed the reported issues. The code now builds cleanly without warnings.Please let me know if you see anything else to improve.