-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Improve ConsolidateBlocks documentation #15890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mtreinish
wants to merge
2
commits into
Qiskit:main
Choose a base branch
from
mtreinish:cons-block-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -59,19 +59,31 @@ class ConsolidateBlocks(TransformationPass): | |||||
| """Replace each block of consecutive gates by a single Unitary node. | ||||||
|
|
||||||
| Pass to consolidate sequences of uninterrupted gates acting on | ||||||
| the same qubits into a Unitary node, to be resynthesized later, | ||||||
| to a potentially more optimal subcircuit. | ||||||
| the same qubits into a :class:`.UnitaryGate` node, to be resynthesized later, | ||||||
| to a potentially more optimal subcircuit. The typical mode of operation of this pass is to run | ||||||
| the analysis of the input :class:`.DAGCircuit` to find all the two qubit blocks in the circuit | ||||||
| and then determine based on an internal heuristic whether that block should be consolidated to | ||||||
| a :class:`.UnitaryGate` or not. However if either ``block_list`` or ``run_list`` are set in the | ||||||
| property set than this pass will not do it's own analysis of the dag. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's -> its |
||||||
|
|
||||||
| There are two legacy modes of operation for this pass based on whether either ``block_list`` or | ||||||
| ``run_list`` is set in the property set when this pass is run. ``block_list`` should contain a | ||||||
| a list of lists of node indices where each inner list represents a collection of blocks to be | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
(a appears twice) |
||||||
| potentially consolidated into a :class:`.UnitaryGate`. These blocks can be any number of qubits | ||||||
| but in previous Qiskit releases' preset pass managers it was typically two and set by the | ||||||
| :class:`.Collect2qBlocks` pass. There is a also the :class:`.CollectMultiQBlocks` transpiler pass | ||||||
| which will set ``blocks_list`` with blocks found for an arbitrary number of qubits. The other property | ||||||
| set key ``run_list`` is a list of lists of "runs" which are single qubit blocks to consolidate. This | ||||||
| was potentially set by the :class:`.Collect1qRuns` transpiler pass. | ||||||
| This functionality for "runs" has been mostly superseded by the :class:`.Optimize1qGatesDecomposition` | ||||||
| transpiler pass and that should typically be used instead for a more thorough and performant | ||||||
| method of simplifying single qubit runs.. | ||||||
|
|
||||||
| This pass reads the :class:`.PropertySet` key ``ConsolidateBlocks_qubit_map`` which it uses to | ||||||
| communicate with recursive worker instances of itself for control-flow operations. The key | ||||||
| should never be observable in a user-facing :class:`.PassManager` pipeline (it is only set in | ||||||
| internal :class:`.PassManager` instances), but the pass may return incorrect results or error if | ||||||
| another pass sets this key. | ||||||
|
|
||||||
| Notes: | ||||||
| This pass assumes that the 'blocks_list' property that it reads is | ||||||
| given such that blocks are in topological order. The blocks are | ||||||
| collected by a previous pass, such as `Collect2qBlocks`. | ||||||
| """ | ||||||
|
|
||||||
| _QUBIT_MAP_KEY = "ConsolidateBlocks_qubit_map" | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"then" may be instead of "than"?