Avoid triggering register/layout warning in remove_final_measurements#16026
Merged
alexanderivrii merged 1 commit intoQiskit:mainfrom Apr 15, 2026
Merged
Conversation
`QuantumCircuit.remove_final_measurements` has always been a bit fragile because it attempts to do effectively in-place deletions of bits of metadata while leaving others intact. Since the "layout" warning is only about modifying the `qregs`, and those are untouched by `remove_final_measurements`, we know that the register modifications are at least safe here and can avoid the warning.
Collaborator
|
One or more of the following people are relevant to this code:
|
mergify Bot
pushed a commit
that referenced
this pull request
Apr 15, 2026
…s` (#16026) `QuantumCircuit.remove_final_measurements` has always been a bit fragile because it attempts to do effectively in-place deletions of bits of metadata while leaving others intact. Since the "layout" warning is only about modifying the `qregs`, and those are untouched by `remove_final_measurements`, we know that the register modifications are at least safe here and can avoid the warning. (cherry picked from commit 1b0276a)
Merged
3 tasks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 15, 2026
…s` (#16026) (#16037) `QuantumCircuit.remove_final_measurements` has always been a bit fragile because it attempts to do effectively in-place deletions of bits of metadata while leaving others intact. Since the "layout" warning is only about modifying the `qregs`, and those are untouched by `remove_final_measurements`, we know that the register modifications are at least safe here and can avoid the warning. (cherry picked from commit 1b0276a) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QuantumCircuit.remove_final_measurementshas always been a bit fragile because it attempts to do effectively in-place deletions of bits of metadata while leaving others intact. Since the "layout" warning is only about modifying theqregs, and those are untouched byremove_final_measurements, we know that the register modifications are at least safe here and can avoid the warning.Fix #16025
AI/LLM disclosure