(Re)implement ndonnx.repeat for all built-in data types#161
Merged
Christian Bourjau (cbourjau) merged 2 commits intomainfrom Aug 13, 2025
Merged
(Re)implement ndonnx.repeat for all built-in data types#161Christian Bourjau (cbourjau) merged 2 commits intomainfrom
Christian Bourjau (cbourjau) merged 2 commits intomainfrom
Conversation
Christian Bourjau (cbourjau)
requested a review
from Aditya Goel (adityagoel4512)
as a code owner
Aditya Goel (adityagoel4512)
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
repeatfor all built-in data types. This is possible since the implementation only relies on other high-level APIs instead of the underlying layout. We used to have an implementation forndonnx.repeatbefore, but it got lost during the refactoring leading up to 0.10.0. The previous implementation usedsearchsortedwhile this one uses broadcasting and reshaping. Either has compromises. The earlier one was likely heavier on the CPU, while this one may be more memory hungry in some circumstances. My gut feeling is that this implementation is the better compromise.The change to the array-api-tests is due to this upstream issue: data-apis/array-api-tests#388
Justin Chu (@justinchuby)