-
Notifications
You must be signed in to change notification settings - Fork 55
[AIROCMLIR-555] Remove mhal.launch and mhal.await from the codebase
#2333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
erizheng-amd
wants to merge
28
commits into
develop
Choose a base branch
from
eric-555
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
6f4a838
experiment on the ticket 555, not working
erizheng-amd fb0b657
Adding temp experiment flag for upcoming change
erizheng-amd f3ebce2
fixing test failure due to IR change
erizheng-amd fefe127
updating tests to check for [1 1 1]
erizheng-amd 6298d6b
update test with explicit call on mhal
erizheng-amd 604bd14
Fixing the compute errors caused by removin mhal functions
erizheng-amd be03d19
Removing redundant includes and experiment flags
erizheng-amd a9ea3c9
Merge branch 'develop' into eric-555
erizheng-amd 89e49c1
Merge branch 'develop' into eric-555
erizheng-amd 8e58246
extra fix after merge
erizheng-amd cd1b606
Fixing Clang-Format issue
erizheng-amd 1a58b33
Merge branch 'develop' into eric-555
erizheng-amd bb21f09
fix nightly lit test errors
erizheng-amd 65067b1
Fix on other lit tests explicitly using mhal launch and mhal await
erizheng-amd 685fca3
Merge branch 'develop' into eric-555
erizheng-amd 92472e8
Merge branch 'develop' into eric-555
erizheng-amd 78a0dcd
Addressing PR comments
erizheng-amd 2111b16
Full removal for mhal.launch and mhal.await support
erizheng-amd 07ed9ad
small fix
erizheng-amd 53c3119
small fix
erizheng-amd fa51897
Merge branch 'develop' into eric-555
erizheng-amd 95a64ad
Merge branch 'develop' into eric-555
erizheng-amd 0f86aa7
Merge branch 'develop' into eric-555
erizheng-amd 7354be4
Addressing AI Agent Reviews
erizheng-amd 8373389
Address AI Review
erizheng-amd 6b9a162
addressing new AI review comments
erizheng-amd 2ea4f82
fix in mlir-hal project
erizheng-amd 4cb8053
Merge branch 'develop' into eric-555
erizheng-amd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
389 changes: 214 additions & 175 deletions
389
external/mlir-hal/lib/Conversion/MHALToGPU/MHALToGPU.cpp
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 5 additions & 6 deletions
11
mlir/test/fusion/pr-e2e/mixr-expand-strides-non-multiple.mlir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.