Skip to content

Enable BinSkim-compliant compile flags#2335

Open
apwojcik wants to merge 4 commits intodevelopfrom
enable_binskim_compliant_flags
Open

Enable BinSkim-compliant compile flags#2335
apwojcik wants to merge 4 commits intodevelopfrom
enable_binskim_compliant_flags

Conversation

@apwojcik
Copy link
Copy Markdown
Contributor

@apwojcik apwojcik commented Apr 8, 2026

PR from the series that is migrating changes from uai-develop to the develop branch.

The PR adds CMake options to enable compilation of rocMLIR on Windows with Spectre mitigated libraries and to add GuardControl to the resulting binaries required for the BinSkim analysis.

Also, it fixes a bug that prevents the rocMLIR compilation on Windows in the Release mode.

@apwojcik apwojcik requested a review from causten as a code owner April 8, 2026 11:57
@apwojcik apwojcik added bug Something isn't working windows uai labels Apr 8, 2026
@apwojcik apwojcik force-pushed the enable_binskim_compliant_flags branch 2 times, most recently from 78144b1 to 30b7d08 Compare April 8, 2026 12:02
@apwojcik apwojcik force-pushed the enable_binskim_compliant_flags branch from 30b7d08 to a251b4d Compare April 8, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working uai windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants