Skip to content

[AIROCMLIR-692] Standardize Jenkins CODEPATH gfx bucket names#2346

Open
bogdan-petkovic wants to merge 2 commits intoROCm:developfrom
bogdan-petkovic:bogdan-petkovic/jenkins-codepath-gfx-naming
Open

[AIROCMLIR-692] Standardize Jenkins CODEPATH gfx bucket names#2346
bogdan-petkovic wants to merge 2 commits intoROCm:developfrom
bogdan-petkovic:bogdan-petkovic/jenkins-codepath-gfx-naming

Conversation

@bogdan-petkovic
Copy link
Copy Markdown
Contributor

@bogdan-petkovic bogdan-petkovic commented Apr 15, 2026

Motivation

Standardize Jenkins CODEPATH naming to a single gfx-based convention for RDNA families and remove mixed naming (navi* + gfx*) in CI matrix routing.
This improves readability and consistency across CODEPATH parameter values, matrix axes, and gating toggles.

Technical Details

This PR performs a hard rename of Jenkins CODEPATH buckets in mlir/utils/jenkins/Jenkinsfile:

  • navi21 -> gfx10x
  • navi3x -> gfx11x
  • navi4x -> gfx12x

Kept unchanged:

  • mfma
  • vanilla
  • gfx950

Test Plan

Static validation:

  • searched for stale references to navi21|navi3x|navi4x|disableNavi* in active CI paths
  • confirmed no remaining references in Jenkins CODEPATH logic

Logic consistency checks:

  • verified all matrix CODEPATH values align with renamed buckets
  • verified all renamed disable toggles are used by gating functions
  • verified CODEPATH-to-attention mapping remains mfma/gfx950 -> mfma, gfx10x/gfx11x/gfx12x -> wmma

Test Result

  • Rename applied consistently across Jenkins CODEPATH routing and gating.
  • No stale navi* / disableNavi* references remain in active Jenkins CODEPATH logic.
  • Expected CI behavior is preserved with only visible CODEPATH naming changed.

CI

  • Nightly
  • Weekly
  • PR

Submission Checklist

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes Jenkins CODEPATH bucket naming in mlir/utils/jenkins/Jenkinsfile by renaming RDNA-family buckets from mixed navi*/gfx* naming to a consistent gfx* convention, while preserving existing CI routing/gating behavior.

Changes:

  • Renamed CODEPATH buckets: navi21 -> gfx10x, navi3x -> gfx11x, navi4x -> gfx12x.
  • Updated all associated routing logic (node label selection, attention sweep mapping, chip-to-codepath mapping) to use the new bucket names.
  • Renamed Jenkins gating toggles from disableNavi* to disableGfx* and updated parameter choices / matrix axes accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bogdan-petkovic bogdan-petkovic force-pushed the bogdan-petkovic/jenkins-codepath-gfx-naming branch from 80b100a to 3db0ecd Compare April 17, 2026 08:21
@bogdan-petkovic bogdan-petkovic marked this pull request as ready for review April 17, 2026 08:25
@bogdan-petkovic bogdan-petkovic force-pushed the bogdan-petkovic/jenkins-codepath-gfx-naming branch from 3db0ecd to 7054ca0 Compare April 20, 2026 11:04
Copy link
Copy Markdown
Contributor

@dorde-antic dorde-antic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@dorde-antic dorde-antic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bogdan-petkovic bogdan-petkovic changed the title Standardize Jenkins CODEPATH gfx bucket names [AIROCMLIR-692] Standardize Jenkins CODEPATH gfx bucket names Apr 21, 2026
Copy link
Copy Markdown
Contributor

@dorde-antic dorde-antic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw we should make sure all ci runs work with this change (todo: kick PR one, nightly, weekly) before merging

Signed-off-by: bogdan-petkovic <bogdan.petkovic@htecgroup.com>
Signed-off-by: bogdan-petkovic <bogdan.petkovic@htecgroup.com>
@bogdan-petkovic bogdan-petkovic force-pushed the bogdan-petkovic/jenkins-codepath-gfx-naming branch from c56e637 to c8dc715 Compare May 5, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants