[CI] Restore navi3x and navi4x CODEPATH values removed in #1898#2355
[CI] Restore navi3x and navi4x CODEPATH values removed in #1898#2355stefankoncarevic merged 3 commits intodevelopfrom
Conversation
dorde-antic
left a comment
There was a problem hiding this comment.
They were removed on purpose, since we didn't do before param sw on navi, and there was a failing conv discovered, so there is a follow up ticket to resolve failing conv before bringing param sw on navi
Thanks for the context! I wasn't aware this was intentional. Closing this PR - will wait for the follow-up ticket to resolve the failing conv first. |
dorde-antic
left a comment
There was a problem hiding this comment.
It seems that initial review was wrong, we actually need this merged
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2355 +/- ##
===========================================
+ Coverage 79.50% 80.55% +1.05%
===========================================
Files 100 125 +25
Lines 31016 42575 +11559
Branches 4819 7008 +2189
===========================================
+ Hits 24659 34294 +9635
- Misses 4245 5663 +1418
- Partials 2112 2618 +506
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Motivation
navi3xandnavi4xvalues to the CODEPATH axis in the Build and Test matrixTechnical Details
Test Plan
Test Result
Submission Checklist