Skip to content

[CI] Restore navi3x and navi4x CODEPATH values removed in #1898#2355

Merged
stefankoncarevic merged 3 commits intodevelopfrom
fix-nightly-build-and-test
May 4, 2026
Merged

[CI] Restore navi3x and navi4x CODEPATH values removed in #1898#2355
stefankoncarevic merged 3 commits intodevelopfrom
fix-nightly-build-and-test

Conversation

@stefankoncarevic
Copy link
Copy Markdown
Contributor

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Copy link
Copy Markdown
Contributor

@dorde-antic dorde-antic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were removed on purpose, since we didn't do before param sw on navi, and there was a failing conv discovered, so there is a follow up ticket to resolve failing conv before bringing param sw on navi

@stefankoncarevic
Copy link
Copy Markdown
Contributor Author

They were removed on purpose, since we didn't do before param sw on navi, and there was a failing conv discovered, so there is a follow up ticket to resolve failing conv before bringing param sw on navi

Thanks for the context! I wasn't aware this was intentional. Closing this PR - will wait for the follow-up ticket to resolve the failing conv first.

Copy link
Copy Markdown
Contributor

@dorde-antic dorde-antic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that initial review was wrong, we actually need this merged

@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2355      +/-   ##
===========================================
+ Coverage    79.50%   80.55%   +1.05%     
===========================================
  Files          100      125      +25     
  Lines        31016    42575   +11559     
  Branches      4819     7008    +2189     
===========================================
+ Hits         24659    34294    +9635     
- Misses        4245     5663    +1418     
- Partials      2112     2618     +506     
Flag Coverage Δ
gfx950 80.36% <ø> (?)
mfma ?
navi4x 80.45% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 106 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefankoncarevic stefankoncarevic merged commit 54f68a1 into develop May 4, 2026
15 checks passed
@stefankoncarevic stefankoncarevic deleted the fix-nightly-build-and-test branch May 4, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants