Skip to content

feat: QoL Improvements to ReVanced Manager#3335

Open
validcube wants to merge 15 commits into
mainfrom
fortune-dam
Open

feat: QoL Improvements to ReVanced Manager#3335
validcube wants to merge 15 commits into
mainfrom
fortune-dam

Conversation

@validcube

@validcube validcube commented May 5, 2026

Copy link
Copy Markdown
Member

Fortune dam!

  1. Add patches version to output logs
  2. Make onboarding app list works like the dashboard app list so that it's slightly faster
  3. Provide feedback when you input invalid value to text field
  4. Allow switching endpoint in downloader (previously was TODO unimplemented)
  5. Don't run autocorrect on URL input
  6. Ask user to verify opsec before doing anything with keystore passwords
  7. Validate source URL first before allowing user to add google.com as a source bundle/downloader
  8. Correct tooltip behaviour, accessibility, and fix tooltip going over safe area (visually)

Other than that is some cleanup/maintenance or small enough to not be a problem

Fixes: #3062
Fixes: #2792

@validcube validcube requested a review from Ushie May 5, 2026 21:15
@oSumAtrIX

Copy link
Copy Markdown
Member

Add patches version to output logs

Which output log? The patch log?

Provide feedback when you input invalid value to text field

How does the feedback look like?

Allow switching endpoint in downloader (previously was TODO unimplemented)

What does this mean? What endpoint?

Ask user to verify opsec before doing anything with keystore passwords

What does this mean? Can you show a screenshot

Validate source URL first before allowing user to add google.com as a source bundle/downloader

What has google.com have to do with downloaders?

@validcube

Copy link
Copy Markdown
Member Author

Add patches version to output logs

Which output log? The patch log?

The patch log

Provide feedback when you input invalid value to text field

How does the feedback look like?

For example, if you put a number in a text only field the input UI will switch to errored state instead of doing nothing about it.

Allow switching endpoint in downloader (previously was TODO unimplemented)

What does this mean? What endpoint?

Endpoint in the code is basically the API url of the source. In this case it's Downloader's URL, (api url of downloader? patch bundles? downloader bundles? just download url? i don't know but it's here https://discord.com/channels/952946952348270622/952987428786941952/1501236781633503443)

Ask user to verify opsec before doing anything with keystore passwords

What does this mean? Can you show a screenshot

Warn user about sensitive action using dialog, which is copy/show password, this only shows once.

https://github.com/ReVanced/revanced-manager/pull/3335/changes#diff-5e01f7d37a66e4ca03deefc205d8e7008661cdd0284a05aaba1858e6b7bf9103R423-R430

Validate source URL first before allowing user to add google.com as a source bundle/downloader

What has google.com have to do with downloaders?

You theoretically shouldn't be able to put google.com or any random URL as source at all:

this feature tldr: https://discord.com/channels/952946952348270622/952987428786941952/1501307464002441316

screenshot 1: https://discord.com/channels/952946952348270622/952987428786941952/1501305128156790966

screenshot 2: https://discord.com/channels/952946952348270622/952987428786941952/1501306417414410262

screenshot 3: https://discord.com/channels/952946952348270622/952987428786941952/1501306111729471510

@PalmDevs PalmDevs self-requested a review May 12, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add patches version in logs bug: Entering an invalid patches source url shows a confusing error message

2 participants