Skip to content

V6 - [WIP]#1179

Draft
danielbarion wants to merge 55 commits intomasterfrom
v6
Draft

V6 - [WIP]#1179
danielbarion wants to merge 55 commits intomasterfrom
v6

Conversation

@danielbarion
Copy link
Copy Markdown
Member

@danielbarion danielbarion commented Mar 14, 2024

  • cleanup of the deprecated options of the Tooltip
  • explore new bundler options (bun.sh?)
  • Rollup upgraded v2 -> v4

Note: we need to consider the custom rollup plugin we did to inject the CSS into the build file (/rollup-plugins/replace-before-save-file.js)

  • check global average browser version and reduce the range on the build that includes polyfills ✅
  • we have different ways to use the tooltip. Check code splitting to reduce the loaded code related to the way the project wants to use react-tooltip
  • improve tooltip performance - how to benchmark it to compare with v5?
  • improve internal state handling (internal state should be updated in the least render cycles possible)
  • review all useMemo()/useCallback()/useEffect() dependencies (the react-hooks/exhaustive-deps rule should only be ignore if strictly necessary, i.e. an specific dependency breaks functionality)
  • break down large effects and functions into more concise (and properly named) functions
  • review docs to make sure it's up to date with V6 changes after PR gets ready to be reviewed
  • write the tests to cover the library code and his utils

@danielbarion danielbarion added the V6 It might get fixed/merged before, but most likely only on V6's release. label Mar 14, 2024
@danielbarion danielbarion changed the title V6 V6 - [WIP] Mar 14, 2024
@danielbarion danielbarion mentioned this pull request Mar 14, 2024
Closed
@gabrieljablonski gabrieljablonski marked this pull request as draft March 14, 2024 18:59
@danielbarion
Copy link
Copy Markdown
Member Author

danielbarion commented Mar 20, 2024

  • Bun is amazing but unfortunately not an option at the moment because of:

image

Also, note added:

Note: we need to consider the custom rollup plugin we did to inject the CSS into the build file (/rollup-plugins/replace-before-save-file.js)

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented May 8, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4462a544-79b7-4bc8-9f3d-7713044bd85f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch v6

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 8, 2024

Beta version released with the last commit 🚀

yarn add react-tooltip@6.0.0-beta.1179.rc.0

or

npm install react-tooltip@6.0.0-beta.1179.rc.0

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 9, 2024

Beta version released with the last commit 🚀

yarn add react-tooltip@6.0.0-beta.1179.rc.1

or

npm install react-tooltip@6.0.0-beta.1179.rc.1

@danielbarion
Copy link
Copy Markdown
Member Author

image

@danielbarion
Copy link
Copy Markdown
Member Author

image

@danielbarion
Copy link
Copy Markdown
Member Author

  • Bun is amazing but unfortunately not an option at the moment because of:

image

Also, note added:

Note: we need to consider the custom rollup plugin we did to inject the CSS into the build file (/rollup-plugins/replace-before-save-file.js)

Almost there:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

V6 It might get fixed/merged before, but most likely only on V6's release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants