Skip to content

Allow deletion of views created by CREATE VIEW queries#60

Merged
ohaibbq merged 2 commits intocandidate/rb20251028from
dankurtz/delete-views-created-via-query
Feb 7, 2026
Merged

Allow deletion of views created by CREATE VIEW queries#60
ohaibbq merged 2 commits intocandidate/rb20251028from
dankurtz/delete-views-created-via-query

Conversation

@incidentist
Copy link
Copy Markdown

Correctly sets view information on table metadata in addTableMetadata, allowing DeleteTables to know that the table is a view and that it should call DROP VIEW on the underlying Sqlite view.

Also fixes a secondary bug in jobsInsertHandler.Handle() where job.JobReference could be nil when submitting jobs without an explicit job reference.

This was written with Claude's help, but verified with testing and code inspection.

Fixes #59

@incidentist incidentist changed the base branch from main to candidate/rb20251028 February 6, 2026 22:29
@incidentist incidentist requested a review from ohaibbq February 6, 2026 22:30
@ohaibbq ohaibbq closed this Feb 6, 2026
@ohaibbq ohaibbq reopened this Feb 6, 2026
Copy link
Copy Markdown

@ohaibbq ohaibbq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!

@ohaibbq ohaibbq merged commit 6e4eb0c into candidate/rb20251028 Feb 7, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Views created via CREATE VIEW SQL can't be deleted with delete_table

2 participants