fix: allow null parameter types; loosen QueryParameterValue marshalling#67
Merged
ohaibbq merged 2 commits intodan/node-testfrom Feb 9, 2026
Merged
fix: allow null parameter types; loosen QueryParameterValue marshalling#67ohaibbq merged 2 commits intodan/node-testfrom
QueryParameterValue marshalling#67ohaibbq merged 2 commits intodan/node-testfrom
Conversation
|
There's a small edge case here. Workaround is to replace int with Edit: |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to depend on the published generated protos for the BigQuery API. These protos type
QueryParameterValue.Valueas a string which is not compatible with how the Python/Node clients send the parameters. This implements custom marshalling to handle cases of null, boolean, and numeric values.closes #58
closes goccy#312
closes goccy#234
closes goccy#137