Skip to content
This repository was archived by the owner on Dec 8, 2020. It is now read-only.
This repository was archived by the owner on Dec 8, 2020. It is now read-only.

useless parsing of tasks #40

@Rocco83

Description

@Rocco83

Hi,

given the code, if the latest job is found with "no new packages" is found, then if checkrepos is "on" all of the tasks are parsed up to find out a task that match the channel that we need for.
We are here at the code

if @options[:checkrepos]

When one repository is found, further check are done

if tasker['input']['repository']['id'] == repo['id']

A deeper check start

def checktask(task, last_date)

When the task is from the past, the code is just skipping this task

puts_verbose "#{task['humanized']['output']} This past task will NOT trigger a Publish."

Wondering if in this section of code, if the task is from the paste, we can skip the remaining tasks.

if ( checktask(tasker, cv_last_published) )

Looking at the code , my understanding is that if a "past task" is found, since the tasks are sorted by ended_at, we can be sure that no other tasks will be found afterwards with packages that are missing.

Any comment?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions