Skip to content

Fix Android 15!#239

Merged
jfversluis merged 3 commits intomainfrom
fix-android15
Aug 28, 2025
Merged

Fix Android 15!#239
jfversluis merged 3 commits intomainfrom
fix-android15

Conversation

@jfversluis
Copy link
Copy Markdown
Collaborator

@jfversluis jfversluis commented Aug 28, 2025

Taken the changes from #216 that were not in #235 to see if that fixes things

Fixes #238
Pretty sure it fixes #215

@mypp74
Copy link
Copy Markdown
Contributor

mypp74 commented Aug 28, 2025

It works for me, and it's better than requiring Android 24.

Just adding
public Android.Util.Size DefaultTargetResolution => null;
seems to work too.

So [SupportedOSPlatform("android24.0")] is no longer necessary?

@jfversluis
Copy link
Copy Markdown
Collaborator Author

Is there any way you would be able to verify that @mypp74 ?

@mypp74
Copy link
Copy Markdown
Contributor

mypp74 commented Aug 28, 2025

I've successfully tested it locally.
https://github.com/mypp74/ZXing.Net.Maui/tree/fix-android15
But it's better if others test it too.

@MFinkBK
Copy link
Copy Markdown

MFinkBK commented Aug 28, 2025

I also tested the built NuGet package, and it works now on the Galaxy A14 device, still with Android 14 (so I think it's not an Android 15 issue). Thanks for fixing it, and so fast!

One nitpick: The built NuGet package ZXing.Net.Maui has the version 0.0.1 in the PR build, so at first, my app project picked up the "0.4.0" package, resulting in the previous crash. Workaround was to force a PackageReference with 0.0.1, and then it worked. It would be good if the NuGet package ZXing.Net.Maui would also get the 0.999.0-ci version, so that testing would be easier. I guess it's a no-issue for "officially" built packages.

@jfversluis jfversluis changed the title Fix Android 15? Fix Android 15! Aug 28, 2025
@jfversluis
Copy link
Copy Markdown
Collaborator Author

@mypp74 good feedback thanks! Applied your changes back to here, can you test again?

@MFinkBK thank you! The version number feedback is good, I'll do that in another PR right now. Sorry to bother you, but I applied some more changes here to make the fix simpler. Can I maybe ask you to test the version resulting from this build? Thanks!

@MFinkBK
Copy link
Copy Markdown

MFinkBK commented Aug 28, 2025

@jfversluis tested again with the build from revision aedf466, also removing the 0.0.1 NuGet package from package cache before building. Still works.

@jfversluis
Copy link
Copy Markdown
Collaborator Author

Thank you so much! I'll merge this and release preview 2. If anything still seems wrong with that for you, please let me know

@jfversluis jfversluis merged commit 3dfe52b into main Aug 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android: crash on starting barcode scanner (0.5.0-preview.1) CommunityToolkit and ZXing conflict

3 participants