Conversation
|
It works for me, and it's better than requiring Android 24. Just adding So [SupportedOSPlatform("android24.0")] is no longer necessary? |
|
Is there any way you would be able to verify that @mypp74 ? |
|
I've successfully tested it locally. |
|
I also tested the built NuGet package, and it works now on the Galaxy A14 device, still with Android 14 (so I think it's not an Android 15 issue). Thanks for fixing it, and so fast! One nitpick: The built NuGet package ZXing.Net.Maui has the version 0.0.1 in the PR build, so at first, my app project picked up the "0.4.0" package, resulting in the previous crash. Workaround was to force a PackageReference with 0.0.1, and then it worked. It would be good if the NuGet package ZXing.Net.Maui would also get the 0.999.0-ci version, so that testing would be easier. I guess it's a no-issue for "officially" built packages. |
|
@mypp74 good feedback thanks! Applied your changes back to here, can you test again? @MFinkBK thank you! The version number feedback is good, I'll do that in another PR right now. Sorry to bother you, but I applied some more changes here to make the fix simpler. Can I maybe ask you to test the version resulting from this build? Thanks! |
|
@jfversluis tested again with the build from revision aedf466, also removing the 0.0.1 NuGet package from package cache before building. Still works. |
|
Thank you so much! I'll merge this and release preview 2. If anything still seems wrong with that for you, please let me know |
Taken the changes from #216 that were not in #235 to see if that fixes things
Fixes #238
Pretty sure it fixes #215