CMake config for IntelLLVM (ifx) and NVIDIA HPC SDK (nvfortran)#898
Merged
weslleyspereira merged 2 commits intoReference-LAPACK:masterfrom Aug 30, 2023
Merged
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #898 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 1918 1918
Lines 188614 188614
=======================================
Misses 188614 188614 ☔ View full report in Codecov by Sentry. |
martin-frbg
approved these changes
Aug 24, 2023
weslleyspereira
approved these changes
Aug 30, 2023
Collaborator
|
Thanks @ACSimon33 ! |
bartoldeman
added a commit
to ComputeCanada/easybuild-computecanada-config
that referenced
this pull request
Oct 3, 2023
ifx is still not mature enough, particularly for complex numbers see also: Reference-LAPACK/lapack#898 and https://community.intel.com/t5/Intel-Fortran-Compiler/IFX-vs-IFORT-performance-difference/m-p/1472018 Adjust optarch dynamically for c/cxx and fortran differently.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated the CMake config to set the correct compiler flags for IntelLLVM (
ifx) and NVIDIA HPC SDK (nvfortran). I testedifxon Linux (oneAPI 2023.2.0) and Windows (oneAPI 2023.1.0). There are still some errors but way less than before (see below).nvfortran(NVIDIA HPC SDK 23.7) is only available on Linux and it works alright. I didn't fix / silence the compiler warnings for now. There are also some numerical errors (see below).ifxtest summary:nvfortrantest summary:Some of the errors are most likely due to non-conforming handling of INF and NAN as both compilers fail some of the Fortran compiler tests (
-DTEST_FORTRAN_COMPILER=ON). We are already working with Intel to resolve the errors inifx.Simon, NAG Ltd.