Skip to content

Supporting Node 22#1617

Merged
RobinTail merged 36 commits intomasterfrom
support-node-22
Apr 24, 2024
Merged

Supporting Node 22#1617
RobinTail merged 36 commits intomasterfrom
support-node-22

Conversation

@RobinTail
Copy link
Copy Markdown
Owner

@RobinTail RobinTail commented Mar 13, 2024 •
edited
Loading

@RobinTail RobinTail added dependencies Pull requests that update a dependency file CI/CD labels Mar 13, 2024
@RobinTail RobinTail changed the title Allowing Node 22 and testing on its nightly build. Supporting Node 22 Mar 13, 2024
RobinTail
RobinTail commented Mar 13, 2024
View reviewed changes
Comment thread package.json Outdated
RobinTail
RobinTail commented Mar 13, 2024
View reviewed changes
Comment thread package.json Outdated
RobinTail
RobinTail commented Mar 13, 2024
View reviewed changes
Comment thread .github/workflows/node.js.yml Outdated
RobinTail
RobinTail commented Mar 13, 2024
View reviewed changes
Comment thread .github/workflows/node.js.yml Outdated
RobinTail
RobinTail commented Mar 13, 2024
View reviewed changes
Comment thread package.json Outdated
@coveralls-official
Copy link
Copy Markdown

coveralls-official Bot commented Mar 13, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 3652b28 on support-node-22
into 42675f5 on master.

@RobinTail
Copy link
Copy Markdown
Owner Author

RobinTail commented Mar 13, 2024

Found this warning in tests, perhaps from some dependency

(node:2078) [DEP0044] DeprecationWarning: The `util.isArray` API is deprecated. Please use `Array.isArray()` instead.

@RobinTail
Copy link
Copy Markdown
Owner Author

RobinTail commented Mar 13, 2024

That comes from form-data

image

@RobinTail
Copy link
Copy Markdown
Owner Author

RobinTail commented Mar 13, 2024

Related issue: form-data/form-data#558

@RobinTail RobinTail mentioned this pull request Mar 13, 2024
Closed
@RobinTail RobinTail added the enhancement New feature or request label Mar 13, 2024
RobinTail
RobinTail commented Mar 19, 2024
View reviewed changes
Comment thread .github/workflows/node.js.yml Outdated
RobinTail
RobinTail commented Apr 5, 2024
View reviewed changes
Comment thread .github/workflows/node.js.yml Outdated
RobinTail
RobinTail commented Apr 5, 2024
View reviewed changes
Comment thread .github/workflows/node.js.yml Outdated
RobinTail
RobinTail commented Apr 24, 2024
View reviewed changes
Comment thread .github/workflows/node.js.yml Outdated
RobinTail
RobinTail commented Apr 24, 2024
View reviewed changes
Comment thread .github/workflows/node.js.yml Outdated
RobinTail
RobinTail commented Apr 24, 2024
View reviewed changes
Comment thread .github/workflows/node.js.yml Outdated
RobinTail
RobinTail commented Apr 24, 2024
View reviewed changes
Comment thread .github/workflows/node.js.yml Outdated
RobinTail
RobinTail commented Apr 24, 2024
View reviewed changes
Comment thread .github/workflows/node.js.yml Outdated
@RobinTail RobinTail marked this pull request as ready for review April 24, 2024 18:46
RobinTail
RobinTail commented Apr 24, 2024
View reviewed changes
Copy link
Copy Markdown
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready

@RobinTail RobinTail merged commit fd0a118 into master Apr 24, 2024
@RobinTail RobinTail deleted the support-node-22 branch April 24, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CI/CD dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@RobinTail
⚡