No confirmation dialog when quitting during file upload

[Ram-sah19]

When a user attempts to close the application while a file upload is in progress, the system immediately quits without displaying any confirmation dialog. This can lead to accidental termination of uploads and potential data loss.

A confirmation prompt should appear to warn the user that an upload is still in progress before exiting the application.

#Steps to Reproduce

Open Rocket.Chat desktop app.

Join any channel or direct message.

Start uploading a file (large file works best).

While the upload is still in progress, attempt to close the application.

The application closes immediately without any warning.

#Expected Behavior

The application should display a confirmation dialog such as:

“A file upload is currently in progress. Are you sure you want to quit?”

This would prevent accidental interruption of uploads.

#Current Behavior

The application closes immediately without any warning or confirmation dialog.

Environment

Rocket.Chat Version: (example: 6.x.x)

Desktop App Version: (example: 4.x.x)

Operating System: Windows 10 / Windows 11 / macOS / Linux

Browser: Not applicable (desktop app)

#Additional Context

This issue affects usability, especially when uploading large files. A confirmation dialog would help prevent accidental interruptions.

[ZunedKhan07]

Hi, I would like to work on this issue. Can I be assigned?

[Ram-sah19]

Hi, I would like to work on this issue. Can I be assigned?

yeah sure

[ZunedKhan07]

Ok, thanks

[ZunedKhan07]

Hi, I would like to work on this issue.

Could you please tell me to the file or module where the file upload state is managed in the desktop app? It would help me get started quickly.

Thanks!

[Ram-sah19]

Hi, I would like to work on this issue.

Could you please tell me to the file or module where the file upload state is managed in the desktop app? It would help me get started quickly.

Thanks!

A good starting point would be to look at the files handling the window and application close events, such as:

app/main.ts

app/mainWindow.ts

You can look for handlers related to events like close, before-quit, or will-quit. The idea would be to intercept the close event and check whether a file upload is currently in progress before allowing the application to exit.

You may also want to search the codebase for keywords like upload, fileUpload, or uploads to see how the upload state is managed.

[ZunedKhan07]

Hi! Since the desktop app loads the Rocket.Chat web client inside a webview, I couldn't find the upload state in the Electron repository.

Should the upload-in-progress check be implemented by querying the webview (for example using webContents.executeJavaScript) or is there already an existing state/event exposed that I should use?

Thanks!

[Ram-sah19]

Hi! Since the desktop app loads the Rocket.Chat web client inside a webview, I couldn't find the upload state in the Electron repository.

Should the upload-in-progress check be implemented by querying the webview (for example using webContents.executeJavaScript) or is there already an existing state/event exposed that I should use?

Thanks!

Hi @ZunedKhan07,

Since this issue was assigned, I haven’t seen any pull request or visible progress for quite some time. To keep the issue tracker clean and allow others to work on it, I will be closing this issue for now.

Thanks for your understanding.