-
Notifications
You must be signed in to change notification settings - Fork 13.5k
fix: warn user when both mobile push and email notifications are enabled #39726 #39731
Copy link
Copy link
Open
Labels
Description
This PR adds a small warning in the notifications preferences
section when user has both mobile push and email notifications
turned on at the same time, which can cause duplicate alerts.
User Experience Improvements:
- added a warning
CalloutinNotificationPreferencesPage
that shows up when bothmobilePushNotificationsand
emailNotificationsare not set tonothing - imported
Calloutfrom@rocket.chat/fuselageinto the
existing import line (no new import added)
Localization:
- added
Mobile_push_and_email_duplicate_warningkey in
en.i18n.jsonfor the warning message
Issue(s)
closes #2839
Steps to test or reproduce
- go to Avatar → My Account → Notifications Preferences
- set Mobile Push Notifications to
Every MessageorEvery Mention - set Email Notifications to
Every MessageorEvery Mention - warning callout should appear below the email field
- set either one back to
Nothingand warning disappears
Further comments
pretty straightforward change, just a conditional render and
one translation string. let me know if the callout should be
placed somewhere else or if the warning message needs rewording
Summary by CodeRabbit
- New Features
- Added a warning in notification preferences that alerts users when both mobile push and email notifications are enabled simultaneously, helping them avoid receiving duplicate notification alerts.
Reactions are currently unavailable