bug: Sidebar items depending on reactive settings do not update until page reload

[MishaB28]

Problem Statement

When an admin changes settings that control sidebar item visibility (for example Feature Preview navigation settings), the Account sidebar does not update reactively and requires a full page reload for the changes to appear.

This was observed when enabling/disabling Feature Preview -> Navigation -> Filters and secondary sidebar, but the issue appears to be related to the sidebar update mechanism itself rather than a specific feature.

Current Behavior

After changing a setting that affects sidebar item visibility, the sidebar does not update immediately. The change is only reflected after a full page reload.

Expected Behavior

Sidebar items should appear immediately after the related setting is changed, without requiring a page reload.

Steps to Reproduce

1. Go to Admin -> Settings -> Accounts
2. Enable Feature Preview
3. Inside Feature Preview, enable Navigation -> Filters and secondary sidebar
4. Navigate back to Home without reloading
5. Observe that the Filters / secondary sidebar does not appear
6. Reload the page
7. The Filters / secondary sidebar now appears

Possible Root Cause

The issue may be related to how sidebar items are managed and updated in 'apps/meteor/client/lib/createSidebarItems.ts' when settings change.

Settings themselves appear to update reactively, but the sidebar/navigation does not re-render until a full page reload, which suggests the sidebar update mechanism may not be reacting to setting changes.

It may be related to how sidebar items are registered or how subscribers are notified when settings change, but this would need confirmation from maintainers.

Suggested Fix (High Level)

Possible approaches could include:

• Ensuring sidebar items are re-evaluated when relevant settings change
• Triggering sidebar updates when reactive settings change
• Reviewing the sidebar subscription/update mechanism

[AyushK5ingh]

I would like to work on this issue

[Pavani12314]

Hi! I’d like to work on this issue. I’ve gone through the description and steps to reproduce, and I’m interested in investigating the reactive update mechanism for the sidebar. Please let me know if it’s still available or if there are any pointers before I begin. Thanks!

[adwait50]

Heyy! Here's the approach im thinking,
Sidebar items are registered only on startup, and thus any check based on settings is only performed on startup and not afterwards. When setting changes afterwards, nothing causes the sidebar to refresh, hence the reload is required.

Fixes would be to put the conditional registration inside Tracker.autorun to run again when the setting is changed and to add a unregisterItem function to createSidebarItems.ts to allow items to be removed when a setting is turned off (not only created when a setting is turned on).

Would be putting up a PR. Thanks!!