Skip to content
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
098c996
added UI validation for existing email during user registration
Anxhul10 Feb 20, 2025
2401105
Add changeset for email validation fix
Anxhul10 Feb 20, 2025
4760feb
Merge branch 'develop' into fix/email-already-registered
Anxhul10 Feb 21, 2025
94aa790
Merge branch 'develop' into fix/email-already-registered
Anxhul10 Feb 21, 2025
0ca1a3e
Merge branch 'develop' into fix/email-already-registered
Anxhul10 Feb 24, 2025
0322f63
fixed lint errors
Anxhul10 Feb 24, 2025
5a7eda0
Merge branch 'develop' into fix/email-already-registered
Anxhul10 Feb 24, 2025
97bceb5
Merge branch 'develop' into fix/email-already-registered
Anxhul10 Feb 25, 2025
0173b0e
Merge branch 'develop' into fix/email-already-registered
Anxhul10 Feb 25, 2025
5155fe6
Merge branch 'develop' into fix/email-already-registered
Anxhul10 Feb 25, 2025
1766d36
Update users.ts
Anxhul10 Feb 25, 2025
4d92b92
Update RegisterForm.tsx
Anxhul10 Feb 25, 2025
29b97c3
Update RegisterForm.tsx
Anxhul10 Feb 25, 2025
1cf131e
Merge branch 'develop' into fix/email-already-registered
Anxhul10 Feb 25, 2025
69e19d4
Merge branch 'develop' into fix/email-already-registered
Anxhul10 Feb 26, 2025
15a3982
Merge branch 'develop' into fix/email-already-registered
Anxhul10 Feb 26, 2025
bfbc470
Merge branch 'develop' into fix/email-already-registered
Anxhul10 Feb 27, 2025
f2bf979
Merge branch 'develop' into fix/email-already-registered
Anxhul10 Feb 28, 2025
cf4f398
Merge branch 'develop' into fix/email-already-registered
Anxhul10 Mar 7, 2025
e169807
Merge branch 'RocketChat:develop' into fix/email-already-registered
Anxhul10 Mar 7, 2025
06b34a8
test: added e2e test for duplicate email validation in user registration
Anxhul10 Mar 13, 2025
12a8283
Merge branch 'RocketChat:develop' into fix/email-already-registered
Anxhul10 Mar 13, 2025
5748771
test:added api for signup, specific locator and separate test block
Anxhul10 Mar 13, 2025
e76f770
fixed lint errors
Anxhul10 Mar 13, 2025
22da7a3
Merge branch 'develop' into fix/email-already-registered
Anxhul10 Mar 13, 2025
2b068b5
Merge branch 'develop' into fix/email-already-registered
Mar 18, 2025
87a987e
Merge branch 'develop' into fix/email-already-registered
Anxhul10 Apr 9, 2025
dbb5436
Merge branch 'develop' into fix/email-already-registered
Anxhul10 Apr 9, 2025
f181ce4
Merge branch 'develop' into fix/email-already-registered
MartinSchoeler Apr 15, 2025
738cb9c
Merge branch 'develop' into fix/email-already-registered
dougfabris Jun 18, 2025
4274758
fix: error locators
dougfabris Jun 18, 2025
cb832c4
Merge branch 'develop' into fix/email-already-registered
kodiakhq[bot] Jun 18, 2025
398a7a9
Merge branch 'develop' into fix/email-already-registered
kodiakhq[bot] Jun 18, 2025
b13e3a8
Merge branch 'develop' into fix/email-already-registered
dougfabris Jun 20, 2025
dc912dd
Merge branch 'develop' into fix/email-already-registered
dougfabris Jun 23, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/open-toes-vanish.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@rocket.chat/meteor': patch
'@rocket.chat/web-ui-registration': patch
---

Fixes email validation in the registration form to prevent users from registering with an already existing email address.
5 changes: 4 additions & 1 deletion apps/meteor/app/api/server/v1/users.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import { sendConfirmationEmail } from '../../../../server/methods/sendConfirmati
import { getUserForCheck, emailCheck } from '../../../2fa/server/code';
import { resetTOTP } from '../../../2fa/server/functions/resetTOTP';
import { hasPermissionAsync } from '../../../authorization/server/functions/hasPermission';
import { checkEmailAvailability } from '../../../lib/server/functions/checkEmailAvailability';
import {
checkUsernameAvailability,
checkUsernameAvailabilityWithValidation,
Expand Down Expand Up @@ -649,7 +650,9 @@ API.v1.addRoute(
if (!(await checkUsernameAvailability(this.bodyParams.username))) {
return API.v1.failure('Username is already in use');
}

if (!(await checkEmailAvailability(this.bodyParams.email))) {
return API.v1.failure('Email is already in use');
}
if (this.bodyParams.customFields) {
try {
await validateCustomFields(this.bodyParams.customFields);
Expand Down
2 changes: 1 addition & 1 deletion packages/web-ui-registration/src/RegisterForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export const RegisterForm = ({ setLoginRoute }: { setLoginRoute: DispatchLoginRo
if (error.errorType === 'error-user-already-exists') {
setError('username', { type: 'user-already-exists', message: t('registration.component.form.usernameAlreadyExists') });
}
if (/Email already exists/.test(error.error)) {
if (/Email is already in use/.test(error.error)) {
setError('email', { type: 'email-already-exists', message: t('registration.component.form.emailAlreadyExists') });
}
if (/Username is already in use/.test(error.error)) {
Expand Down