chore: Add tmid field in the ChatPostMessage request body schema#36093
chore: Add tmid field in the ChatPostMessage request body schema#36093ahmed-n-abdeltwab wants to merge 12 commits intoRocketChat:developfrom
tmid field in the ChatPostMessage request body schema#36093Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36093 +/- ##
===========================================
- Coverage 70.86% 70.85% -0.02%
===========================================
Files 3160 3160
Lines 109775 109775
Branches 19709 19707 -2
===========================================
- Hits 77795 77777 -18
- Misses 29957 29969 +12
- Partials 2023 2029 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
8811b37 to
3797d55
Compare
|
The |
tmid field in the ChatPostMessage request body schema
WalkthroughThis pull request extends the Chat API to support threaded replies via the tmid (thread message ID) parameter and adds end-to-end tests validating the threaded reply functionality. The type definitions have been updated to accept tmid in the postMessage payload, and two comprehensive test cases verify the feature works correctly across different room creation methods. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Proposed changes
Add the
tmidattribute to theChatPostMessagechannel request body schema to resolve the Python SDK issue when posting messages using tmid.Issue(s)
Relates to #35923;
Looking forward to your feedback! 🚀
Summary by CodeRabbit
Release Notes
Tests
New Features
✏️ Tip: You can customize this high-level summary in your review settings.