feat: New Collapse component for Apps logs#36142
Merged
kodiakhq[bot] merged 17 commits intodevelopfrom Jun 21, 2025
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 72ee6be The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
0ecc31b to
9a3600e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #36142 +/- ##
===========================================
+ Coverage 64.54% 64.80% +0.26%
===========================================
Files 3148 3153 +5
Lines 104632 104788 +156
Branches 19775 19963 +188
===========================================
+ Hits 67530 67913 +383
+ Misses 34416 34186 -230
- Partials 2686 2689 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
tassoevan
reviewed
Jun 9, 2025
apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppLogs/AppLogs.tsx
Outdated
Show resolved
Hide resolved
d-gubert
previously approved these changes
Jun 11, 2025
Member
d-gubert
left a comment
There was a problem hiding this comment.
Looks good from apps perspective
d-gubert
previously requested changes
Jun 16, 2025
tassoevan
approved these changes
Jun 17, 2025
d-gubert
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Rewrites the existing log items to use a new component, using Accordions in this page could lead to accessibility issues due the Accordion "Title" not being a title per se. Also some visuals where updated to a new design
Issue(s)
ALT-8