Skip to content

chore: remove useReactiveValue from usePermissionsAndRoles#36240

Merged
kodiakhq[bot] merged 5 commits intodevelopfrom
chore/usePermissionsAndRoles
Jun 24, 2025
Merged

chore: remove useReactiveValue from usePermissionsAndRoles#36240
kodiakhq[bot] merged 5 commits intodevelopfrom
chore/usePermissionsAndRoles

Conversation

@juliajforesti
Copy link
Copy Markdown
Contributor

@juliajforesti juliajforesti commented Jun 17, 2025

ARCH-1655

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jun 17, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 17, 2025

⚠️ No Changeset found

Latest commit: 0e7e56d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 17, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36240/

Built to branch gh-pages at 2025-06-23 23:49 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@juliajforesti juliajforesti force-pushed the chore/usePermissionsAndRoles branch from 1b99700 to 5886383 Compare June 17, 2025 22:42
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.83%. Comparing base (dd20d85) to head (0e7e56d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36240      +/-   ##
===========================================
- Coverage    64.83%   64.83%   -0.01%     
===========================================
  Files         3153     3153              
  Lines       104787   104795       +8     
  Branches     19962    19967       +5     
===========================================
- Hits         67941    67940       -1     
- Misses       34156    34164       +8     
- Partials      2690     2691       +1     
Flag Coverage Δ
e2e 57.69% <92.85%> (+0.04%) ⬆️
unit 69.59% <20.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliajforesti juliajforesti force-pushed the chore/usePermissionsAndRoles branch from 60efe1d to 382cf7e Compare June 18, 2025 18:07
@juliajforesti juliajforesti force-pushed the chore/usePermissionsAndRoles branch from 382cf7e to 0c0739f Compare June 18, 2025 21:41
@juliajforesti juliajforesti marked this pull request as ready for review June 20, 2025 17:37
@juliajforesti juliajforesti requested a review from a team as a code owner June 20, 2025 17:37
@tassoevan tassoevan added this to the 7.9.0 milestone Jun 20, 2025
@juliajforesti juliajforesti requested a review from tassoevan June 20, 2025 22:26
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jun 23, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 23, 2025
@kodiakhq kodiakhq bot merged commit d9f0fba into develop Jun 24, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the chore/usePermissionsAndRoles branch June 24, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants