Skip to content

chore(deps): Mismatched and missing dev dependencies#36257

Merged
ggazzo merged 13 commits intodevelopfrom
chore/deps
Jun 25, 2025
Merged

chore(deps): Mismatched and missing dev dependencies#36257
ggazzo merged 13 commits intodevelopfrom
chore/deps

Conversation

@tassoevan
Copy link
Copy Markdown
Member

@tassoevan tassoevan commented Jun 19, 2025

https://rocketchat.atlassian.net/browse/ARCH-1687

Proposed changes (including videos or screenshots)

It eliminates some warnings during yarn install.

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jun 19, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 19, 2025

⚠️ No Changeset found

Latest commit: 0378314

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 19, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36257/

Built to branch gh-pages at 2025-06-25 20:47 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.81%. Comparing base (d7bfba3) to head (0378314).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36257      +/-   ##
===========================================
- Coverage    64.83%   64.81%   -0.03%     
===========================================
  Files         3153     3153              
  Lines       104812   104812              
  Branches     19969    19968       -1     
===========================================
- Hits         67955    67931      -24     
- Misses       34173    34192      +19     
- Partials      2684     2689       +5     
Flag Coverage Δ
e2e 57.70% <ø> (ø)
unit 69.55% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan tassoevan force-pushed the chore/deps branch 20 times, most recently from a9caa15 to 482f8c0 Compare June 24, 2025 23:59
@tassoevan tassoevan marked this pull request as ready for review June 25, 2025 21:38
@tassoevan tassoevan requested review from a team as code owners June 25, 2025 21:38
@tassoevan tassoevan added this to the 7.9.0 milestone Jun 25, 2025
@ggazzo ggazzo merged commit 9ea2635 into develop Jun 25, 2025
51 checks passed
@ggazzo ggazzo deleted the chore/deps branch June 25, 2025 21:46
ahmed-n-abdeltwab pushed a commit to ahmed-n-abdeltwab/Rocket.Chat that referenced this pull request Jun 26, 2025
sem22-dev pushed a commit to sem22-dev/Rocket.Chat that referenced this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants