Skip to content

fix: parseUrls parameter not working in chat.postMessage#36265

Merged
kodiakhq[bot] merged 5 commits intodevelopfrom
fix/parseUrls-params-chat.postMessage
Jul 16, 2025
Merged

fix: parseUrls parameter not working in chat.postMessage#36265
kodiakhq[bot] merged 5 commits intodevelopfrom
fix/parseUrls-params-chat.postMessage

Conversation

@abhinavkrin
Copy link
Copy Markdown
Member

@abhinavkrin abhinavkrin commented Jun 20, 2025

Proposed changes (including videos or screenshots)

Restores support for the parseUrls boolean parameter in chat.postMessage. Currently passing this param caused the endpoint to return error.

  • Reintroduced parseUrls into the chat.postMessage payload validation schema.

Issue(s)

Steps to test or reproduce

Further comments

SUP-809

@abhinavkrin abhinavkrin requested review from a team as code owners June 20, 2025 19:32
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jun 20, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 20, 2025

🦋 Changeset detected

Latest commit: 4bd1a00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/rest-typings Patch
@rocket.chat/meteor Patch
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/http-router Patch
@rocket.chat/models Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/network-broker Patch
@rocket.chat/livechat Patch
@rocket.chat/mock-providers Patch
@rocket.chat/cron Patch
@rocket.chat/instance-status Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/core-typings Patch
@rocket.chat/apps Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@abhinavkrin abhinavkrin added this to the 7.9.0 milestone Jun 20, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 20, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36265/

Built to branch gh-pages at 2025-07-16 17:33 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.49%. Comparing base (95072bb) to head (4bd1a00).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36265      +/-   ##
===========================================
- Coverage    65.52%   65.49%   -0.03%     
===========================================
  Files         3168     3168              
  Lines       105098   105098              
  Branches     20016    20009       -7     
===========================================
- Hits         68866    68837      -29     
- Misses       33556    33582      +26     
- Partials      2676     2679       +3     
Flag Coverage Δ
e2e 58.21% <ø> (-0.03%) ⬇️
unit 70.59% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@abhinavkrin abhinavkrin force-pushed the fix/parseUrls-params-chat.postMessage branch from 96d33fb to ef70c4e Compare July 16, 2025 13:08
@abhinavkrin abhinavkrin added the stat: QA assured Means it has been tested and approved by a company insider label Jul 16, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 16, 2025
@kodiakhq kodiakhq bot merged commit 0de9318 into develop Jul 16, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/parseUrls-params-chat.postMessage branch July 16, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants