Skip to content

chore: remove migration 319#36300

Merged
ggazzo merged 1 commit intodevelopfrom
chore/migration-319-remove
Jun 25, 2025
Merged

chore: remove migration 319#36300
ggazzo merged 1 commit intodevelopfrom
chore/migration-319-remove

Conversation

@ggazzo
Copy link
Copy Markdown
Member

@ggazzo ggazzo commented Jun 24, 2025

https://rocketchat.atlassian.net/browse/ARCH-1685
introduced here: #36259

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jun 24, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 24, 2025

⚠️ No Changeset found

Latest commit: 98fdfc0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36300/

Built to branch gh-pages at 2025-06-24 23:46 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.82%. Comparing base (542971f) to head (98fdfc0).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36300      +/-   ##
===========================================
+ Coverage    64.81%   64.82%   +0.01%     
===========================================
  Files         3153     3153              
  Lines       104812   104812              
  Branches     19966    19970       +4     
===========================================
+ Hits         67929    67944      +15     
+ Misses       34197    34183      -14     
+ Partials      2686     2685       -1     
Flag Coverage Δ
e2e 57.70% <ø> (+<0.01%) ⬆️
unit 69.57% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo added this to the 7.8.0 milestone Jun 24, 2025
@ggazzo ggazzo marked this pull request as ready for review June 24, 2025 23:52
@ggazzo ggazzo requested a review from a team as a code owner June 24, 2025 23:52
Copy link
Copy Markdown
Member

@tassoevan tassoevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jun 25, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 25, 2025
@ggazzo ggazzo merged commit d7bfba3 into develop Jun 25, 2025
49 of 51 checks passed
@ggazzo ggazzo deleted the chore/migration-319-remove branch June 25, 2025 02:52
ahmed-n-abdeltwab pushed a commit to ahmed-n-abdeltwab/Rocket.Chat that referenced this pull request Jun 26, 2025
sem22-dev pushed a commit to sem22-dev/Rocket.Chat that referenced this pull request Jul 4, 2025
MartinSchoeler pushed a commit that referenced this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants