fix: REST api v1 not enforcing rate limiter#36313
Merged
kodiakhq[bot] merged 3 commits intodevelopfrom Jul 16, 2025
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: d812c90 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36313 +/- ##
===========================================
+ Coverage 65.50% 65.52% +0.01%
===========================================
Files 3169 3169
Lines 105177 105187 +10
Branches 20029 20038 +9
===========================================
+ Hits 68896 68920 +24
+ Misses 33602 33591 -11
+ Partials 2679 2676 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
5fd2389 to
99c0b4d
Compare
MarcosSpessatto
approved these changes
Jul 15, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR fixes the issue of Rate Limiter not being enforced. Rate-limit rules are defined with version prefixed paths (e.g. /v1/rooms.get), but the limiter was receiving malformed keys like /rooms.getget, so no v1 endpoints were ever rate-limited.
Since, the lookup for the current route in the rateLimiter config dictionary always failed.
getFullRouteName()a public method onAPIClass.Issue(s)
CORE-1236
Steps to test or reproduce
Further comments