fix: change sanitizeUrl to handle URLs without a protocol schema#36317
Merged
kodiakhq[bot] merged 4 commits intodevelopfrom Jul 2, 2025
Merged
fix: change sanitizeUrl to handle URLs without a protocol schema#36317kodiakhq[bot] merged 4 commits intodevelopfrom
kodiakhq[bot] merged 4 commits intodevelopfrom
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 929a56a The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36317 +/- ##
========================================
Coverage 64.78% 64.78%
========================================
Files 3153 3153
Lines 104879 104870 -9
Branches 19986 19979 -7
========================================
- Hits 67946 67943 -3
+ Misses 34247 34234 -13
- Partials 2686 2693 +7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
abhinavkrin
reviewed
Jun 27, 2025
abhinavkrin
reviewed
Jun 27, 2025
abhinavkrin
approved these changes
Jun 27, 2025
sem22-dev
pushed a commit
to sem22-dev/Rocket.Chat
that referenced
this pull request
Jul 4, 2025
MartinSchoeler
pushed a commit
that referenced
this pull request
Jul 10, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
After adding a new function that sanitizes URLs and blocks the usage of dangerous protocol schemas such as
javascript:, a bug was introduced. URLs without a predefined protocol will return#:This PR changes that behavior to ensure that URLs without a predefined protocol will return a protocol-relative URL:
URLs with protocols are returned normally:
While dangerous protocol schemas are blocked:
Issue(s)
CORE-1215
Steps to test or reproduce
N/A
Further comments
N/A