refactor: update ExtractValidation type to use 'unknown'#36318
Merged
kodiakhq[bot] merged 4 commits intoRocketChat:developfrom Jun 29, 2025
Merged
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
cardoso
requested changes
Jun 27, 2025
cardoso
reviewed
Jun 27, 2025
3f15b10 to
0a587a3
Compare
d405d25 to
cd8c5da
Compare
Contributor
Author
|
This is also an issue with POST; perhaps changes could also be made to POST, PUT, etc. |
cardoso
approved these changes
Jun 29, 2025
sem22-dev
pushed a commit
to sem22-dev/Rocket.Chat
that referenced
this pull request
Jul 4, 2025
MartinSchoeler
pushed a commit
that referenced
this pull request
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
description:
Change the ExtractValidation type to return 'unknown' instead of 'never' for the case where the params return never'. Instead of never, unknown should be good.
Tests: