fix: properly throw error objects to apps on runtime#36346
Merged
kodiakhq[bot] merged 3 commits intodevelopfrom Jul 4, 2025
Merged
fix: properly throw error objects to apps on runtime#36346kodiakhq[bot] merged 3 commits intodevelopfrom
kodiakhq[bot] merged 3 commits intodevelopfrom
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: d673b5e The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36346 +/- ##
===========================================
- Coverage 64.92% 64.92% -0.01%
===========================================
Files 3156 3156
Lines 104827 104827
Branches 19930 19928 -2
===========================================
- Hits 68063 68062 -1
- Misses 34078 34081 +3
+ Partials 2686 2684 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
d-gubert
force-pushed
the
fix/apps-error-responses
branch
2 times, most recently
from
88d7b53 to
bc16472
Compare
d-gubert
force-pushed
the
fix/apps-error-responses
branch
from
b6eec5b to
d673b5e
Compare
ggazzo
approved these changes
Jul 3, 2025
d-gubert
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Member
Author
|
/patch |
Contributor
after that just run |
ggazzo
pushed a commit
that referenced
this pull request
Jul 4, 2025
Merged
d-gubert
added a commit
that referenced
this pull request
Jul 4, 2025
Member
Author
|
/patch |
Contributor
|
Pull request #36360 added to Project: "Patch 7.7.4" |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Deno runtime was inconsistently handling the propagation of error objects when it received an error response from JsonRPC.
Now apps will always receive instances of
Errorif their accessor method calls fail.Issue(s)
Steps to test or reproduce
Further comments
SUP-823