Skip to content

fix: Unneded inquiry notifier when updating an SLA #36532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 4 commits into from
Jul 25, 2025
Merged

fix: Unneded inquiry notifier when updating an SLA #36532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb2baa6
remove projection
KevLehman Jul 25, 2025
aa46690
add projection and remove notifier
KevLehman Jul 25, 2025
422981e
Create beige-geese-fail.md
KevLehman Jul 25, 2025
3930cc3
Merge branch 'develop' into fix/notifier-sending-incomplete-data
kodiakhq[bot] Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/beige-geese-fail.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/meteor': patch
---

Fixes an issue with SLA policies that caused an inquiry to "dissapear" after its SLA being updated
8 changes: 1 addition & 7 deletions apps/meteor/ee/app/livechat-enterprise/server/lib/SlaHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,7 @@ import { Message } from '@rocket.chat/core-services';
import type { IOmnichannelServiceLevelAgreements, IUser } from '@rocket.chat/core-typings';
import { LivechatInquiry, LivechatRooms } from '@rocket.chat/models';

import {
notifyOnLivechatInquiryChanged,
notifyOnRoomChangedById,
notifyOnLivechatInquiryChangedByRoom,
} from '../../../../../app/lib/server/lib/notifyListener';
import { notifyOnRoomChangedById, notifyOnLivechatInquiryChangedByRoom } from '../../../../../app/lib/server/lib/notifyListener';
import { callbacks } from '../../../../../lib/callbacks';

export const removeSLAFromRooms = async (slaId: string, userId: string) => {
Expand Down Expand Up @@ -36,8 +32,6 @@ export const updateInquiryQueueSla = async (roomId: string, sla: Pick<IOmnichann
slaId,
estimatedWaitingTimeQueue,
});

void notifyOnLivechatInquiryChanged({ ...inquiry, slaId, estimatedWaitingTimeQueue }, 'updated');
};

export const updateRoomSlaWeights = async (roomId: string, sla: Pick<IOmnichannelServiceLevelAgreements, 'dueTimeInMinutes' | '_id'>) => {
Expand Down
Loading
⚡