-
Notifications
You must be signed in to change notification settings - Fork 13.5k
test(message-parser): decouple parser tests from production helpers #39086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ggazzo
merged 2 commits into
RocketChat:develop
from
Shreyas2004wagh:fix/message-parser-oracle-coupling-tests
Feb 26, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| const generate = | ||
| <Type extends string>(type: Type) => | ||
| <Value>(value: Value) => | ||
| ({ type, value }) as const; | ||
|
|
||
| export const paragraph = generate('PARAGRAPH'); | ||
| export const bold = generate('BOLD'); | ||
|
|
||
| export const color = (r: number, g: number, b: number, a = 255) => ({ | ||
| type: 'COLOR' as const, | ||
| value: { r, g, b, a }, | ||
| }); | ||
|
|
||
| export const heading = (value: unknown[], level = 1) => ({ | ||
| type: 'HEADING' as const, | ||
| level, | ||
| value, | ||
| }); | ||
|
|
||
| export const code = (value: unknown[], language = 'none') => ({ | ||
| type: 'CODE' as const, | ||
| language, | ||
| value, | ||
| }); | ||
|
|
||
| export const bigEmoji = generate('BIG_EMOJI'); | ||
| export const task = (value: unknown[], status: boolean) => ({ type: 'TASK' as const, status, value }); | ||
| export const inlineCode = generate('INLINE_CODE'); | ||
| export const tasks = generate('TASKS'); | ||
|
|
||
| export const italic = generate('ITALIC'); | ||
| export const spoiler = generate('SPOILER'); | ||
|
|
||
| export const plain = generate('PLAIN_TEXT'); | ||
| export const strike = generate('STRIKE'); | ||
|
|
||
| export const codeLine = generate('CODE_LINE'); | ||
|
|
||
| export const link = (src: string, label?: unknown[]) => ({ | ||
| type: 'LINK' as const, | ||
| value: { src: plain(src), label: label ?? [plain(src)] }, | ||
| }); | ||
|
|
||
| export const image = (src: string, label?: unknown) => ({ | ||
| type: 'IMAGE' as const, | ||
| value: { src: plain(src), label: label ?? plain(src) }, | ||
| }); | ||
|
|
||
| export const quote = generate('QUOTE'); | ||
| export const spoilerBlock = generate('SPOILER_BLOCK'); | ||
|
|
||
| export const mentionChannel = (value: string) => ({ | ||
| type: 'MENTION_CHANNEL' as const, | ||
| value: plain(value), | ||
| }); | ||
|
|
||
| export const orderedList = generate('ORDERED_LIST'); | ||
| export const unorderedList = generate('UNORDERED_LIST'); | ||
|
|
||
| export const listItem = (value: unknown[], number?: number) => ({ | ||
| type: 'LIST_ITEM' as const, | ||
| value, | ||
| ...(number !== undefined ? { number } : {}), | ||
| }); | ||
|
|
||
| export const mentionUser = (value: string) => ({ | ||
| type: 'MENTION_USER' as const, | ||
| value: plain(value), | ||
| }); | ||
|
|
||
| export const emoji = (shortCode: string) => ({ | ||
| type: 'EMOJI' as const, | ||
| value: plain(shortCode), | ||
| shortCode, | ||
| }); | ||
|
|
||
| export const emojiUnicode = (unicode: string) => ({ | ||
| type: 'EMOJI' as const, | ||
| value: undefined, | ||
| unicode, | ||
| }); | ||
|
|
||
| export const emoticon = (value: string, shortCode: string) => ({ | ||
| type: 'EMOJI' as const, | ||
| value: plain(value), | ||
| shortCode, | ||
| }); | ||
|
|
||
| export const lineBreak = () => ({ | ||
| type: 'LINE_BREAK' as const, | ||
| value: undefined, | ||
| }); | ||
|
|
||
| export const katex = (value: string) => ({ | ||
| type: 'KATEX' as const, | ||
| value, | ||
| }); | ||
|
|
||
| export const inlineKatex = (value: string) => ({ | ||
| type: 'INLINE_KATEX' as const, | ||
| value, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Duplicate AST builder helpers are redefined inline instead of importing the shared test helpers, increasing maintenance overhead and contradicting the test-helper reuse guideline.
Prompt for AI agents