refactor(uikit-playground): Adapt to linting changes#39162
Merged
dionisio-bot[bot] merged 9 commits intodevelopfrom Feb 28, 2026
Merged
refactor(uikit-playground): Adapt to linting changes#39162dionisio-bot[bot] merged 9 commits intodevelopfrom
dionisio-bot[bot] merged 9 commits intodevelopfrom
Conversation
…returning function JSX attribute
Contributor
|
Looks like this PR is ready to merge! 🎉 |
|
tassoevan
changed the title
Contributor
|
Important Review skippedToo many files! This PR contains 173 files, which is 23 over the limit of 150. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (173)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
/jira ARCH-1935 |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 174 files
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/uikit-playground/src/Components/PersistStore/PersistStore.tsx">
<violation number="1" location="apps/uikit-playground/src/Components/PersistStore/PersistStore.tsx:15">
P2: `useEffect` should return a cleanup function. This line calls `removeEventListener` immediately and returns `void`, so the unload handler is never cleaned up; it also doesn’t match the `onbeforeunload` property assignment. Return a cleanup function and clear/reset the handler (or use add/removeEventListener with the correct event name).</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
apps/uikit-playground/src/Components/PersistStore/PersistStore.tsx
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #39162 +/- ##
===========================================
- Coverage 70.70% 70.66% -0.04%
===========================================
Files 3195 3195
Lines 113106 113106
Branches 20513 20493 -20
===========================================
- Hits 79970 79932 -38
- Misses 31088 31127 +39
+ Partials 2048 2047 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ggazzo
approved these changes
Feb 27, 2026
ggazzo
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
It applies the new centralized ESLint rules over the
@rocket.chat/uikit-playgroundworkspace.Issues
Related to #38989.
Further comments
It workspace demanded a set of isolated ESLint rules and its own Prettier configuration. While most of the changes were autofixed and/or easy to adapt, there is some level of refactoring involved that demands careful code review.
Task: ARCH-2013